feat(rest): endpoint to get attachmentUsages for a project. #2103
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Code looks ok. But there are some additional fields in the response which is not required for the page. I believe. It would be good if that can be removed. Please refer this to ignore the booleans in the response. |
0743fb9 to
91a11c4
Compare
|
Hi @smrutis1, additional fields removed. |
smrutis1
requested changes
Oct 25, 2023
| @@ -118,6 +118,7 @@ | |||
| import org.springframework.web.bind.annotation.RestController; | |||
| import org.springframework.web.multipart.MultipartFile; | |||
| import org.springframework.web.servlet.support.ServletUriComponentsBuilder; | |||
| import org.eclipse.sw360.rest.resourceserver.release.ReleaseController; | |||
There was a problem hiding this comment.
Please remove unused imports
There was a problem hiding this comment.
removed the unused imports.
| for (Map.Entry<String, Object> entry : releaseIdToUsage.entrySet()) { | ||
| Map<String, Object> originalValue = (Map<String, Object>) entry.getValue(); | ||
| if (originalValue != null) { | ||
| originalValue.remove("setCreatedBy"); |
There was a problem hiding this comment.
It would be good to create constants of the fields like "setCreatedBy" etc. and remove all from the map
91a11c4 to
071152d
Compare
smrutis1
reviewed
Oct 31, 2023
...ce-server/src/main/java/org/eclipse/sw360/rest/resourceserver/project/ProjectController.java
Outdated
Show resolved
Hide resolved
Signed-off-by: rudra-superrr <rudra.chopra@siemens.com>
071152d to
acc553b
Compare
smrutis1
approved these changes
Nov 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: closes #2094
Description: updated the existing attachmentUsages endpoint with more fields in response structure.