-
Notifications
You must be signed in to change notification settings - Fork 102
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(UI/REST): Package Portlet #1999
feat(UI/REST): Package Portlet #1999
Conversation
@akapti Is Work in Progress or is in review state ? |
f34db24
to
e1fa4cc
Compare
@akapti, thanks for creating this PR , |
d73f31f
to
7703c86
Compare
Hi All,
CC: @ag4ums @heliocastro @smrutis1 @afsahsyeda @KoukiHama @arunazhakesan |
9d2709b
to
0c4e466
Compare
we need to deal with these results, but I will review the latest one tomorrow as codes review and general test with some options in sw360 properties. |
I tried basic functions, it works fine. How about making new Private_Pages_7_4_3_18_GA18.lar ? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have some comments, please take a look.
backend/src-common/src/main/java/org/eclipse/sw360/cyclonedx/CycloneDxBOMImporter.java
Outdated
Show resolved
Hide resolved
backend/src-common/src/main/java/org/eclipse/sw360/cyclonedx/CycloneDxBOMImporter.java
Show resolved
Hide resolved
backend/src-common/src/main/java/org/eclipse/sw360/cyclonedx/CycloneDxBOMImporter.java
Outdated
Show resolved
Hide resolved
backend/src-common/src/main/java/org/eclipse/sw360/datahandler/db/ComponentDatabaseHandler.java
Outdated
Show resolved
Hide resolved
backend/src-common/src/main/java/org/eclipse/sw360/datahandler/db/ComponentDatabaseHandler.java
Outdated
Show resolved
Hide resolved
...e-server/src/main/java/org/eclipse/sw360/rest/resourceserver/packages/PackageController.java
Outdated
Show resolved
Hide resolved
7826579
to
5e3c422
Compare
3a24726
to
7ad3b1d
Compare
7ad3b1d
to
4a94905
Compare
Signed-off-by: akapti <abdul.kapti@siemens-healhtineers.com> feat(REST): REST endpoints for Package portlet Signed-off-by: afsahsyeda <afsah.syeda@siemens-healhtineers.com>
4a94905
to
d356bc0
Compare
@tienlee |
Hi @smrutis1 , Your review comments have been incorporated. Please have a look |
Package
portlet is a new feature in SW360.Package
portlet is the third hierarchy level in SW360 afterComponents
andReleases
.Package
information is stored.Packages
and link it toReleases
orProjects
.Importer
atProject
homepage &Project
details page (supportsJSON
&XML
format).VCS
is available inSBOM
then import by grouping VCS, and createComponent
,Release
&Package
.VCS
isnot
available inSBOM
then import without grouping and create onlyPackage
without linkedRelease
.SBOM
used for import as an attachment inProject
.Package
portlet homepage UI (listing of all packages).Release
information (likeRelease name with version
andRelease Clearing State
).Package
and DeletePackage
buttons (Deletion is possible ifPackage
is not used in anyProject
).Package
page fromPackage
portlet homepage.Package
Edit page.Release
to / from thePackage
.Package
(if not used in anyProject
).Package
Details page.Summary
tab.Projects
Table inPackage
Summary tab.Change Log
tab.Release
Details page.Packages
tab.Edit
&Delete
thePackages
(Deletion is possible ifPackage
is not used in anyProject
).Search
andFilter
forLinked Packages
table.Release
Edit page.Packages
(only OrphanPackages
can be searched & Linked to aRelease
).Packages
.Release
if there are LinkedPackages
in it.Project
Details page.Packages
tab.Release
information in LinkedPackages
tab.Packages
.Search
andFilter
forLinked Packages
table.Releases
inLicense Clearing
tab.Project
Edit page.Packages
.Packages
.Release
when it's only linkedPackage
is removed fromProject
(whenProject
is updated).Release
(if not already linked) when one of it's linkedPackages
is linked to theProject
(whenProject
is updated).Package
portlet feature configurable. (viasw360.properties
:package.portlet.enabled=true
-> default isfalse
)SBOM
import status inJSON
form as attachment inProject
.SBOM
import status from anImportStatus.json
attachment inProject
.Search
forPackages
inSearch
portlet.Moderation Requests
for Packages, Hence restrictPackage
Edit / Update functionality toCreator
ofPackage
or user with minimum role ofClearing Admin
, User role should be configurable(via
sw360.properties
:package.portlet.write.access.usergroup=USER
-> default role isUSER
).Exporter
at Project details page (supportsJSON
&XML
format).POST
endpoint to Create a singlePackage
.PATCH
endpoint to Update aPackage
.DELETE
endpoint to delete aPackage
(Deletion is possible ifPackage
is not used in anyProject
).GET
endpoint to Get a singlePackage
with all details.PATCH
endpoint to link / unlinkPackage
to / fromProject
.POST
endpoint to Import CycloneDX SBOM atProject
level.PATCH
endpoint to link / unlinkPackage
to / fromRelease
.GET
endpoint to list allPackages
with minimal details.GET
endpoint to list allPackages
with all details.GET
endpoint to list allPackages
byname
&package manager type
.Package Manager
other than the list mentioned below.SW360
to support any other SBOM than the one listed below.Package
cannot be deleted if it's already linked to anyProject
.Release
cannot be deleted if it contains linkedPackages
.Release
fromRelease
edit page.Package
toProject
should also link it'sRelease
to project (ifRelease
is not already linked).Package
from theProject
should also unlink it'sRelease
from theProject
(ifPackage
is linked to aRelease
).Project
homepage, a newProject
(if not already present) will be created withname
andversion
as that of thecomponent
present inmetadata
tag ofSBOM
being imported by user.Project
details page will not validate thecomponent
present inmetadata
tag ofSBOM
and import all it's components based on logic mentioned above.UI & Backend
: @akaptiREST API
: @afsahsyedaIssue: #1146 #1374
Suggest Reviewer
@smrutis1
How To Test?
Will share a detailed description on how to test the PR with all use cases.
Checklist
Must: