Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: Move to pnpm #409

Merged
merged 1 commit into from
Dec 19, 2024
Merged

refactor: Move to pnpm #409

merged 1 commit into from
Dec 19, 2024

Conversation

heliocastro
Copy link
Contributor

Move the main package manager to pnpm

@heliocastro heliocastro requested a review from deo002 December 16, 2024 18:13
@heliocastro heliocastro self-assigned this Dec 16, 2024
@heliocastro heliocastro force-pushed the feat/pnpm branch 8 times, most recently from 241c523 to 1ec9b6b Compare December 16, 2024 18:33
@heliocastro
refactor: Move to pnpm
082a596 
Signed-off-by: Helio Chissini de Castro <heliocastro@gmail.com>
@heliocastro
Copy link
Contributor Author

@hoangnt2 The change for pnpm has an interesting side effect, is running cypress tests by default.

hoangnt2
hoangnt2 approved these changes Dec 17, 2024
View reviewed changes
Copy link
Contributor

@hoangnt2 hoangnt2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Look good to me

@hoangnt2
Copy link
Contributor

@heliocastro Sorry, but what do you mean by 'is running Cypress tests by default'?

@heliocastro
Copy link
Contributor Author

Pnpm runs all cypress work that your team did during the build now. So not only the performance for build/instal increased, and lint tests run, but all cypress tests too.

@hoangnt2
Copy link
Contributor

@heliocastro we are using e2e testing strategy for cypress, so a running application is needed for testing. Running cypress while building application will cause it to error

@heliocastro
Copy link
Contributor Author

@heliocastro we are using e2e testing strategy for cypress, so a running application is needed for testing. Running cypress while building application will cause it to error

No no, build check the cypress tests, if all is ready to run.

@heliocastro heliocastro merged commit 700892e into main Dec 19, 2024
4 checks passed
@heliocastro heliocastro deleted the feat/pnpm branch December 19, 2024 16:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hoangnt2 hoangnt2 hoangnt2 approved these changes

@deo002 deo002 Awaiting requested review from deo002

Assignees

@heliocastro heliocastro

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@heliocastro @hoangnt2