Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

git: Remove requirement for commit body to reference an issue #117

Closed

Conversation

AlexanderLanin
Copy link
Member

Referencing an issue is not required according to GD_GUIDL__Contr_Request_Guidance.

Referencing an issue is not required according to GD_GUIDL__Contr_Request_Guidance.
Issue-Ref: see eclipse-score#84
Copy link
Member

@ltekieli ltekieli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Commit message is described in git guidelines and still requires issue-ref:

@ltekieli
Copy link
Member

ltekieli commented Dec 17, 2024

I'd rather vote for some defined prefix that will skip the "Issue-ref" check. "fixup:", "chore:" that explicitly indicates that the official process is omitted. The sentence:
For simple contributions, like fixing bugs or improvements, just creating a PR is sufficient. is too subjective, and just skipping the issue ref completely also is not really valid.

@AlexanderLanin
Copy link
Member Author

I guess this qualifies as a non simple contribution. So I'll create an issue :-)

@AlexanderLanin
Copy link
Member Author

As the discussion will take some time, I'll close this PR for now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants