-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improvement: Refactor Gitlint Workflow to Support Dedicated Omit Word #131
Comments
Let's wait for the discussion in #119. |
Commits are linked by Github to the PR that introduced them. It is impossible to merge a commit without PR. Hence, it is sufficient if the PR links to issues. We have no tooling that would verify that the linkage of a commit is correct. Thus, making an issue reference in the commit message mandatory holds no benefit. It is still allowed to reference an issue in a commit message. It is simply no longer mandatory. Issue-ref: closes #131 Issue-ref: closes #119
Commits are linked by Github to the PR that introduced them. It is impossible to merge a commit without PR. Hence, it is sufficient if the PR links to issues. We have no tooling that would verify that the linkage of a commit is correct. Thus, making an issue reference in the commit message mandatory holds no benefit. It is still allowed to reference an issue in a commit message. It is simply no longer mandatory. Issue-ref: closes #131 Issue-ref: closes #119
Commits are linked by Github to the PR that introduced them. It is impossible to merge a commit without PR. Hence, it is sufficient if the PR links to issues. We have no tooling that would verify that the linkage of a commit is correct. Thus, making an issue reference in the commit message mandatory holds no benefit. It is still allowed to reference an issue in a commit message. It is simply no longer mandatory. Issue-ref: closes #131 Issue-ref: closes #119
Commits are linked by Github to the PR that introduced them. It is impossible to merge a commit without PR. Hence, it is sufficient if the PR links to issues. We have no tooling that would verify that the linkage of a commit is correct. Thus, making an issue reference in the commit message mandatory holds no benefit. It is still allowed to reference an issue in a commit message. It is simply no longer mandatory. Issue-ref: see #131 Issue-ref: closes #119
The title of the issue does not really reflect the acceptance criteria. @nradakovic would you mind adjusting the title to what the issue is about? |
@nradakovic I'll close this issue as it focuses on issue-ref. I know there is a valid part remaining regarding a gitlint workflow. Let's create a new issue for that in case we still want to do that? (reopen this issue in case I'm wrong!) |
Background
The current gitlint implementation in our GitHub workflows enforces checks such as the Issue-ref: validation in commit messages. While effective, it lacks flexibility for scenarios where commits do not need to reference an issue. To address this limitation, we propose introducing a dedicated omit word (e.g., NO-ISSUE) to bypass the Issue-ref: check.
Additionally, we aim to refactor this workflow into a standalone repository. This will enable us to publish the workflow on GitHub Marketplace, making it reusable and accessible to a broader audience.
Objectives
Acceptance Criteria
Proposed Steps
Resources
Impact
The text was updated successfully, but these errors were encountered: