Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The Create target reference page doesn't work well on Windows #121

Closed
merks opened this issue May 23, 2022 · 1 comment
Closed

The Create target reference page doesn't work well on Windows #121

merks opened this issue May 23, 2022 · 1 comment
Assignees
@merks
Milestone
4.24 RC1

Comments

@merks
Copy link
Contributor

merks commented May 23, 2022

Attempting to use file:${project_loc:/<project-name>}/ results in a URI syntax error:

image

The logic implemented by org.eclipse.pde.internal.core.target.RemoteTargetHandle.get(String), which calls org.eclipse.pde.internal.core.target.RemoteTargetHandle.convertRawToUri(String) should be reused.

It would also be nice if the dialog simply listed the available *.target files in the workspace.
@merks merks self-assigned this May 23, 2022
@merks
Copy link
Contributor Author

merks commented May 23, 2022

This is what I've implemented. I.e., the logic is reused so that there is no validation error and I populated the dropdown with the available *.target files in the workspace (excluding the target definition itself of course).

image

merks added a commit to merks/eclipse.pde that referenced this issue May 23, 2022
@merks
Ensure that file:${project_loc:/project}/my.target validates on Windows
29c806c 
as a location URI in  the 'Create target reference' page

Also provide choices of available workspace *.target files in the
drop-down of the 'Create target reference' page

eclipse-pde#121
@merks merks mentioned this issue May 23, 2022
Merged
merks added a commit that referenced this issue May 23, 2022
@merks
Ensure that file:${project_loc:/project}/my.target validates on Windo…
f1bb7c1 
…ws (#122)

as a location URI in  the 'Create target reference' page

Also provide choices of available workspace *.target files in the
drop-down of the 'Create target reference' page

#121
@merks merks closed this as completed May 23, 2022
@vik-chand vik-chand added this to the 4.24 RC1 milestone May 24, 2022
@merks merks mentioned this issue Jun 21, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@merks merks

Labels
None yet
Projects
None yet
Milestone
4.24 RC1
Development

No branches or pull requests
2 participants
@merks @vik-chand