-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix broken OSGi Declarative Service definition files of different Registry implementations #1362
Conversation
Just relying on the generated DS-component files as implemented in #1363, would avoid such errors in the future. |
...enses.core/OSGI-INF/org.eclipse.passage.loc.internal.licenses.core.LicenseDomainRegistry.xml
Show resolved
Hide resolved
@HannesWell
|
That's right, I just created a PR since the fix seemed obvious to me and I assumed that no discussion will be necessary. Having an extra issue that is just opened with the same description of this PR and closed when this PR is merged seems just overhead, I have elaborated more on this in #1363 (comment). If the description is not clear, please let me know. But if you start an Eclipse app with the current master that contains
That's right they should not be fixed manually, but at the moment the files in git have not been regenerated after recent changes in Passage. So I didn't fixed them manually but just re-build the affected bundles and their DS component XML files. To avoid such discrepancies in the future and avoid the need to keep them in sync I created #1363.
Because the other ones are not broken. |
Having a ticket for PR is mandatory in this project. The whole collaboration could grow lighter if you come to respect Passage development rules. In the ticket please place a feasible and repeatable explanation on how to gain the failure. |
See #1364. |
@eparovyshnaya, @ruspl-afed now that a ticket exists I hope this can be resolved quickly, at least before the 3.0.0 release. |
The changed files all need to reference scr-v1.3.0 Fixes eclipse-passage#1364
2f0c4b5
to
8071192
Compare
@HannesWell thank you for focusing our attention on this issue! |
In the current master build starting an Eclipse application that contains the bundle
org.eclipse.passage.loc.licenses.core
ororg.eclipse.passage.loc.products.core
fails with the error below and theLicenseDomainRegistry
,ProductDomainRegistry
andProductOperatorServiceImpl
cannot be obtained as OSGi service because their DS component description files need to referencescr-v1.3.0
instead of only1.1.0
.Fixes #1364.