Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve tests #31

Merged
merged 2 commits into from
Apr 27, 2020
Merged

Improve tests #31

merged 2 commits into from
Apr 27, 2020

Conversation

mickaelistria
Copy link
Contributor

No description provided.

@mickaelistria mickaelistria force-pushed the tests branch 3 times, most recently from 58b9cb9 to c642f99 Compare April 27, 2020 16:14
Signed-off-by: Mickael Istria <mistria@redhat.com>
+ Enable tests in CI

Signed-off-by: Mickael Istria <mistria@redhat.com>
@AObuchow
Copy link
Contributor

This will be merged very soon, I'm just trying to investigate why LocalPluginTest.testPluginArtifactHover is now failing for me locally when it wasn't failing on master branch locally.

@AObuchow
Copy link
Contributor

Odd... LocalPluginTest.testPluginArtifactHover passes when running JUnit tests in Eclipse IDE but fails when running mvn verify with:

java.lang.NullPointerException
        at org.eclipse.lemminx.maven.test.LocalPluginTest.testPluginArtifactHover(LocalPluginTest.java:87)

@AObuchow AObuchow changed the title Tests Improve tests Apr 27, 2020
@AObuchow
Copy link
Contributor

I couldn't figure out the above issue but I'm going to merge anyhow as this patch is a big improvement with regards to making tests more stable on CI

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants