Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

validate element in plugin <configuration> #30

Merged
merged 1 commit into from
Apr 28, 2020
Merged

validate element in plugin <configuration> #30

merged 1 commit into from
Apr 28, 2020

Conversation

AObuchow
Copy link
Contributor

Fix #9

Signed-off-by: Andrew Obuchowicz aobuchow@redhat.com

@AObuchow
Copy link
Contributor Author

This PR still needs a bit of work although it's functional

@AObuchow AObuchow force-pushed the validate_plugin_configuration branch from 6dcd346 to f5d144c Compare April 25, 2020 06:20
@AObuchow AObuchow force-pushed the validate_plugin_configuration branch 2 times, most recently from 263e29b to 6a16aa3 Compare April 27, 2020 17:52
@AObuchow AObuchow force-pushed the validate_plugin_configuration branch from 6a16aa3 to 98b44e0 Compare April 27, 2020 17:57
@AObuchow
Copy link
Contributor Author

To reduce code duplication in MavenPluginUtils and DOMUtils, DiagnosticRequest should implement the IPositionRequest interface.

@AObuchow AObuchow force-pushed the validate_plugin_configuration branch 6 times, most recently from 5cfdfcb to e052083 Compare April 28, 2020 17:24
@AObuchow AObuchow force-pushed the validate_plugin_configuration branch from e052083 to 456c914 Compare April 28, 2020 17:28
AObuchow
AObuchow commented Apr 28, 2020
View reviewed changes
lemminx-maven/src/main/java/org/eclipse/lemminx/maven/DiagnosticRequest.java
}

@Override
public <T> T getComponent(Class clazz) {
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mickaelistria I think this patch is good, except I dislike the fact that I left some methods unimplemented. It should be ok for now, but calling these functions could lead to problems for DiagnosticRequest's.

@AObuchow
validate element in plugin <configuration> and plugin goals
f955e33 
Fix eclipse-lemminx#9

Signed-off-by: Andrew Obuchowicz <aobuchow@redhat.com>
@AObuchow AObuchow force-pushed the validate_plugin_configuration branch from 456c914 to f955e33 Compare April 28, 2020 17:59
@AObuchow
Copy link
Contributor Author

AObuchow commented Apr 28, 2020 •
edited
Loading

@mickaelistria I'm going to merge this since it's now mentioned in the README ;) I think it should be good enough for now, although some things in the MavenDiagnosticParticipant could be done more elegantly in the future.

@AObuchow AObuchow merged commit bca9145 into eclipse-lemminx:master Apr 28, 2020
@markuswernig markuswernig mentioned this pull request Mar 7, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

validate element in plugin <configuration>
1 participant
@AObuchow