Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

added .nvmrc #1791

Merged
merged 2 commits into from
Jan 20, 2025
Merged

added .nvmrc #1791

merged 2 commits into from
Jan 20, 2025

Conversation

cdietrich
Copy link
Contributor

No description provided.

@cdietrich
added .nvmrc
7f7e014 
Signed-off-by: Christian Dietrich <christian.dietrich.opensource@gmail.com>
msujew
msujew reviewed Jan 20, 2025
View reviewed changes
Copy link
Member

@msujew msujew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this makes sense. As an additional change, can you make the GitHub Actions use this specific node version? You can replace the node-version: '18' with node-version-file: '.nvmrc' in all .yml files.

@cdietrich cdietrich requested a review from msujew January 20, 2025 14:04
msujew
msujew approved these changes Jan 20, 2025
View reviewed changes
Copy link
Member

@msujew msujew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@cdietrich cdietrich merged commit f8dadea into main Jan 20, 2025
5 checks passed
@cdietrich cdietrich deleted the cd-nvmrc branch January 20, 2025 14:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@msujew msujew msujew approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cdietrich @msujew