Skip to content
This repository has been archived by the owner on Sep 2, 2024. It is now read-only.

adds CSV provider #77

Merged
merged 3 commits into from
May 11, 2023

Conversation

eriksven
Copy link
Contributor

@eriksven eriksven commented Apr 6, 2023

This PR adds a provider which reads VSS signals from a given CSV-file and replays this data and the changes over time to an instance of the kuksa.val databroker.

@SebastianSchildt
Copy link
Contributor

Not really something, that needs to be added here, just an idea: a helper script creating these .csv from a "life" system is probably easy to do: Give it a list of VSS paths, and it can depending on metadata, subscribe current value for sensors and current&target value for actuators while writing a CSV file. (Don't forget to flush on Ctrl-C :) ). But just an idea for the future

@eriksven eriksven force-pushed the feature/csv-provider branch 2 times, most recently from d632cf5 to ddd02ce Compare April 19, 2023 07:05
@eriksven
Copy link
Contributor Author

I updated the branch for the CSV-provider, @erikbosch and @SebastianSchildt could you please have another look.

The idea of having a script to generate the CSV-files from a life system is good. To me this is beyond the scope of this PR but I will have look into it for a further PR.

@eriksven eriksven force-pushed the feature/csv-provider branch from 23fb3af to 97212c5 Compare April 24, 2023 13:02
@eriksven eriksven force-pushed the feature/csv-provider branch from 97212c5 to 4611c76 Compare April 28, 2023 11:57
Copy link
Contributor

@lukasmittag lukasmittag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just some minor comment regarding documentation. Decide for yourself if you want to rephrase or not.

@SebastianSchildt SebastianSchildt merged commit 7046c2c into eclipse-kuksa:main May 11, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants