This repository has been archived by the owner on Sep 2, 2024. It is now read-only.
Github CI cleanup as part of 0.4.0 release prep #128
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove some useless builds Make sure they trigger the same way Note: DDS is not published to ghcr.io, not changed
lukasmittag
reviewed
Jul 27, 2023
| @@ -19,6 +19,7 @@ on: | |||
| pull_request: | |||
| paths: | |||
| - ".github/workflows/someip2val_build.yml" | |||
| - ".github/workflows/check_push_rights.yml" | |||
| - "someip2val/**" | |||
There was a problem hiding this comment.
what about - ".github/actions/post-container-location/action.yml"? included in the other ones but here not
There was a problem hiding this comment.
Yes, at the moment someip2val does not use that action, so no need to depend on it. We could potentially try to align how we use thata ction when/if we add ddds2val docker push to ttl/ghcr as part of CI
There was a problem hiding this comment.
Okay, just wanted to confirm that it is wanted :)
lukasmittag
approved these changes
Jul 27, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove some useless builds
Make sure they trigger the same way
Note: DDS is not published to ghcr.io, not changed