Skip to content
This repository has been archived by the owner on Sep 2, 2024. It is now read-only.

Fix kuksa-client dependencies #120

Merged
merged 1 commit into from
Jul 6, 2023
Merged

Fix kuksa-client dependencies #120

merged 1 commit into from
Jul 6, 2023

Conversation

erikbosch
Copy link
Contributor

It seems we use cache when calling pypi, but we want a fresh build

@erikbosch erikbosch mentioned this pull request Jul 4, 2023
Closed
sophokles73
sophokles73 reviewed Jul 5, 2023
View reviewed changes
.github/workflows/kuksa_csv_provider.yml Outdated
@@ -95,6 +95,7 @@ jobs:
linux/arm64
file: ./csv_provider/Dockerfile
context: ./csv_provider/
no_cache: true
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the Action's build output seems to suggest that this needs to be no-cache: true instead ...

@sophokles73
Copy link
Contributor

Just for my understanding: you now expect the building of the container to fail, because it will not be able to resolve the (alpha) 4.0.x version, right?

@erikbosch erikbosch changed the title Make sure to use no cache for CSV provider Fix kuksa-client dependencies Jul 5, 2023
@erikbosch
Copy link
Contributor Author

@sophokles73 - When updating the kuksa-client dependencies earlier I made a mistake, I thought > 0.3 would not match 0.3.1 but that seems to be the case. Not a problem if you use --pre, especially not in CI/Docker builds where you start from scratch. So this PR now updates minimum version to latest kuksa-client pre-release, and adds --prefor csv provider.

Separately I tried to improve https://github.com/eclipse/kuksa.val.feeders/wiki/Release-Process. When we do a release we need to remove --pre and change version, when releasing the feeders possibly even choose a fixed version to make it possible to rebuild using exactly the same version.

sophokles73
sophokles73 reviewed Jul 5, 2023
View reviewed changes
dds2val/requirements/requirements-test.txt Outdated
@@ -3,4 +3,4 @@ pytest-html
pytest-cov
pytest-asyncio
py
kuksa-client > 0.3
kuksa-client > 0.4a4
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

shouldn't this also be >=, assuming that 0.4a4 is the most recent pre-release?

@erikbosch erikbosch marked this pull request as ready for review July 6, 2023 06:38
@erikbosch erikbosch requested review from sophokles73 and lukasmittag and removed request for sophokles73 July 6, 2023 06:38
@erikbosch
Copy link
Contributor Author

@lukasmittag @sophokles73 - please check if you think this one is OK for merge now

lukasmittag
lukasmittag approved these changes Jul 6, 2023
View reviewed changes
Copy link
Contributor

@lukasmittag lukasmittag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@sophokles73
Copy link
Contributor

I have started the ephemeral image and did not run into the original problem anymore.
LGTM

@erikbosch erikbosch merged commit 85ec754 into eclipse-kuksa:main Jul 6, 2023
@erikbosch erikbosch deleted the erik_csv branch September 29, 2023 09:35
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@sophokles73 sophokles73 sophokles73 left review comments

@lukasmittag lukasmittag lukasmittag approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@erikbosch @sophokles73 @lukasmittag