Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[VSCode Integration] Improve dispatching of actions that originate in the host extension #1259

Closed
tortmayr opened this issue Feb 18, 2024 · 0 comments
Closed

[VSCode Integration] Improve dispatching of actions that originate in the host extension #1259

tortmayr opened this issue Feb 18, 2024 · 0 comments
Assignees
@tortmayr
Labels
enhancement New feature or request vscode

Comments

@tortmayr
Copy link
Contributor

When dispatching an action in the host extension (e.g. SaveModel, ExportSvg etc.) adopters currently have to manually define
whether the action should be sent to the client, the server or both.
However, both client and server already provide information about their handled actions so we could grab this information in the WebviewEndpoint and introduce automatic dispatching to the correct handling target (client/server) for actions issued by the host extension.
@tortmayr tortmayr added enhancement New feature or request vscode labels Feb 18, 2024
@tortmayr tortmayr mentioned this issue Feb 18, 2024
Merged
2 tasks
tortmayr added a commit to eclipse-glsp/glsp-vscode-integration that referenced this issue Feb 19, 2024
@tortmayr
GLSP-1259 Introduce proper dispatching of actions issued from the hos…
25e7cdd 
…t extension

Introduce `dispatchAction` method in `GLSPVSCodeConnector`. 
This method uses the handled action kinds provided by server/client to determine wether the action should be forwarded to client and/or server.

Deprecate `sendActionToActiveClient` and `sendActionToClient` methods (and use `dispatchAction` internally).

Fixes eclipse-glsp/glsp#1259
tortmayr added a commit to eclipse-glsp/glsp-vscode-integration that referenced this issue Feb 19, 2024
@tortmayr
GLSP-1259 Introduce proper dispatching of actions issued from the hos…
5729c60 
…t extension

Introduce `dispatchAction` method in `GLSPVSCodeConnector`. 
This method uses the handled action kinds provided by server/client to determine wether the action should be forwarded to client and/or server.

Deprecate `sendActionToActiveClient` and `sendActionToClient` methods (and use `dispatchAction` internally).

Fixes eclipse-glsp/glsp#1259
@tortmayr tortmayr self-assigned this Feb 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tortmayr tortmayr

Labels
enhancement New feature or request vscode
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@tortmayr