Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enhance accessibility of GLSP diagrams via keyboard #1029

Closed
4 tasks done
ndoschek opened this issue Jun 5, 2023 · 5 comments
Closed
4 tasks done

Enhance accessibility of GLSP diagrams via keyboard #1029

ndoschek opened this issue Jun 5, 2023 · 5 comments
Labels
client enhancement New feature or request

Comments

@ndoschek
Copy link
Contributor

ndoschek commented Jun 5, 2023 •
edited
Loading

As part of a @aylin-sarioglu's diploma research conducted at the Model Engineering lab of TU Wien in the Business Informatics Group, there are currently there are three main features planned to improve accessibility for GLSP diagrams:

The following PRs are also planned as part of this great endeavour:

To do until the accessibility feature is completed (feel free to extract it out into own GH issues):

  • Provide additional accessibility module that we want to include by default (e.g. everything except grid selection on element creation, focus tracker and toast messages) and enable it as part of the defaults (follow-up issue Provide additional default accessibility module #1128)
  • VS Code integration (follow-up issue Enable accessibility features for VSCode integration #1129)
    • Externalize keyboard shortcuts into Theia-native keybindings to make them configurable for Theia users
    • Fix up styling of the help
    • Fix up visibility / styling of the focus tracker and toast messages
  • Theia integration (follow-up issue Enable accessibility features for Theia integration #1130)
    • Externalize keyboard shortcuts into Theia-native keybindings to make them configurable for Theia users
    • Fix up styling of the help
    • Fix up visibility / styling of the focus tracker and toast messages
  • Eclipse integration (follow-up issue Enable accessibility features for Eclipse integration #1131)
    • Externalize keyboard shortcuts into Theia-native keybindings to make them configurable for Theia users
    • Fix up styling of the help
    • Fix up visibility / styling of the focus tracker and toast messages
@ndoschek ndoschek added the enhancement New feature or request label Jun 5, 2023
ndoschek pushed a commit to eclipse-glsp/glsp-client that referenced this issue Jun 5, 2023
@aylin-sarioglu
#1029 Introduce search palette that can find nodes and edges through …
6c2f3cc 
…autocomplete with the capability to visually highlight found elements. (#242)

- Introduce base class for autocomplete palettes supporting flexible suggestions
- Extend AutoCompleteWidget with visibleSuggestionsChanged and selectedSuggestionChanged callbacks
- Provide reason if AutoCompleteWidget closes

Part of eclipse-glsp/glsp#1029
This was referenced Jun 5, 2023
Merged
Merged
Merged
ndoschek pushed a commit to eclipse-glsp/glsp-client that referenced this issue Jun 6, 2023
@aylin-sarioglu
Introduce moving and zooming of the viewport and elements via the key…
c54a4b8 
…board (#241)

- Introduce tool and handler for moving viewport and elements via keyboard shortcut
- Introduce tool and handler for zooming viewport and elements via keyboard shortcut
- Provide tool for an improved implementation for deselecting elements

Part of eclipse-glsp/glsp#1029
ndoschek pushed a commit to eclipse-glsp/glsp-client that referenced this issue Jun 6, 2023
@aylin-sarioglu @ndoschek
#1029 Introduce moving and zooming of the viewport and elements via t…
97e90c6 
…he keyboard (#241)

- Introduce tool and handler for moving viewport and elements via keyboard shortcut
- Introduce tool and handler for zooming viewport and elements via keyboard shortcut
- Provide tool for an improved implementation for deselecting elements

Part of eclipse-glsp/glsp#1029
@ndoschek ndoschek added the client label Jun 6, 2023
ndoschek pushed a commit to eclipse-glsp/glsp-client that referenced this issue Jun 7, 2023
@aylin-sarioglu
#1029 Introduce resizing elements via the keyboard (#240)
6d6e326 
-  Introduce tool and handler for resizing elements via keyboard shortcut

Part of eclipse-glsp/glsp#1029
This was referenced Jun 16, 2023
Merged
Merged
ndoschek pushed a commit that referenced this issue Jun 16, 2023
@aylin-sarioglu
#1029 Extend feature list by adding accessibility features (#1036)
d45032c 
Part of #1029
ndoschek pushed a commit to eclipse-glsp/glsp-client that referenced this issue Jun 19, 2023
@aylin-sarioglu
#1029 Add documentation for accessibility features (#254)
d81a1ea 
- Search
- Move
- Zoom
- Resize

Part of eclipse-glsp/glsp#1029
@aylin-sarioglu aylin-sarioglu mentioned this issue Jul 7, 2023
Merged
@tortmayr
Copy link
Contributor

@martin-fleck-at Can this be closed?

@martin-fleck-at
Copy link
Contributor

@tortmayr Afaik, yes. I don't think there is any work pending in this regard. I'll close the issue for now. @ndoschek If you expect more work to be done, please feel free to re-open.

@aylin-sarioglu aylin-sarioglu mentioned this issue Aug 20, 2023
Merged
@ndoschek
Copy link
Contributor Author

Yes, there are still two features expected (as mentioned in the PR description). Hence I'll reopen this issue, one of those PRs was opened already.

@ndoschek ndoschek reopened this Aug 21, 2023
ndoschek pushed a commit to eclipse-glsp/glsp-client that referenced this issue Aug 25, 2023
@aylin-sarioglu
GLSP-1029: Introducing element navigation via keyboard (#276)
976795c 
-  Introduce tool and handler for element navigation via keyboard shortcut
-  Introduce tool and handler for tracking the current focus of the cursor
-  Introduce tool and handler for the creation of notification/toast
-  Introduce new reposition action for focusing on element without zooming in

Part of eclipse-glsp/glsp#1029
@planger
Copy link
Member

planger commented Sep 11, 2023

I added the open tasks into description but suggest we do the first task (provide default accessibility tool) rather soon, and extract separate issues for the platform integrations, so that we can close this task.
Thank you very much for this excellent work!

ndoschek pushed a commit to eclipse-glsp/glsp-client that referenced this issue Oct 3, 2023
@aylin-sarioglu
GLSP-1029: Introducing accessible tool palette, node and edge creatio…
9f38884 
…n via keyboard (#279)

-  Introduce tool and handler for Grid and Pointer for node creation

-  Introduce tool and handler for edge creation with autocomplete feature

-  Introduce tool and handler zooming via grid

Part of eclipse-glsp/glsp#1029
This was referenced Oct 3, 2023
Open
Open
Open
@ndoschek ndoschek mentioned this issue Oct 3, 2023
Open
3 tasks
@ndoschek
Copy link
Contributor Author

ndoschek commented Oct 3, 2023

Closing this as the base of accessibility features for GLSP were completed in the scope of the standalone example.
For enabling accessibility features for the different integrations, follow-up issues were created (see description).

@ndoschek ndoschek closed this as completed Oct 3, 2023
holkerveen pushed a commit to holkerveen/glsp-client that referenced this issue Dec 21, 2024
@aylin-sarioglu @holkerveen
#1029 Introduce search palette that can find nodes and edges through …
8c5f524 
…autocomplete with the capability to visually highlight found elements. (eclipse-glsp#242)

- Introduce base class for autocomplete palettes supporting flexible suggestions
- Extend AutoCompleteWidget with visibleSuggestionsChanged and selectedSuggestionChanged callbacks
- Provide reason if AutoCompleteWidget closes

Part of eclipse-glsp/glsp#1029
holkerveen pushed a commit to holkerveen/glsp-client that referenced this issue Dec 21, 2024
@aylin-sarioglu @holkerveen
#1029 Introduce moving and zooming of the viewport and elements via t…
c4ee455 
…he keyboard (eclipse-glsp#241)

- Introduce tool and handler for moving viewport and elements via keyboard shortcut
- Introduce tool and handler for zooming viewport and elements via keyboard shortcut
- Provide tool for an improved implementation for deselecting elements

Part of eclipse-glsp/glsp#1029
holkerveen pushed a commit to holkerveen/glsp-client that referenced this issue Dec 21, 2024
@aylin-sarioglu @holkerveen
#1029 Introduce resizing elements via the keyboard (eclipse-glsp#240)
097b1e9 
-  Introduce tool and handler for resizing elements via keyboard shortcut

Part of eclipse-glsp/glsp#1029
holkerveen pushed a commit to holkerveen/glsp-client that referenced this issue Dec 21, 2024
@aylin-sarioglu @holkerveen
#1029 Add documentation for accessibility features (eclipse-glsp#254)
ca9ed39 
- Search
- Move
- Zoom
- Resize

Part of eclipse-glsp/glsp#1029
holkerveen pushed a commit to holkerveen/glsp-client that referenced this issue Dec 21, 2024
@aylin-sarioglu @holkerveen
GLSP-1029: Introducing element navigation via keyboard (eclipse-glsp#276
5ece568 
)

-  Introduce tool and handler for element navigation via keyboard shortcut
-  Introduce tool and handler for tracking the current focus of the cursor
-  Introduce tool and handler for the creation of notification/toast
-  Introduce new reposition action for focusing on element without zooming in

Part of eclipse-glsp/glsp#1029
holkerveen pushed a commit to holkerveen/glsp-client that referenced this issue Dec 21, 2024
@aylin-sarioglu @holkerveen
GLSP-1029: Introducing accessible tool palette, node and edge creatio…
1d206be 
…n via keyboard (eclipse-glsp#279)

-  Introduce tool and handler for Grid and Pointer for node creation

-  Introduce tool and handler for edge creation with autocomplete feature

-  Introduce tool and handler zooming via grid

Part of eclipse-glsp/glsp#1029
holkerveen pushed a commit to holkerveen/glsp-client that referenced this issue Dec 21, 2024
@aylin-sarioglu @holkerveen
#1029 Introduce search palette that can find nodes and edges through …
84ea397 
…autocomplete with the capability to visually highlight found elements. (eclipse-glsp#242)

- Introduce base class for autocomplete palettes supporting flexible suggestions
- Extend AutoCompleteWidget with visibleSuggestionsChanged and selectedSuggestionChanged callbacks
- Provide reason if AutoCompleteWidget closes

Part of eclipse-glsp/glsp#1029
holkerveen pushed a commit to holkerveen/glsp-client that referenced this issue Dec 21, 2024
@aylin-sarioglu @holkerveen
#1029 Introduce moving and zooming of the viewport and elements via t…
e85cd33 
…he keyboard (eclipse-glsp#241)

- Introduce tool and handler for moving viewport and elements via keyboard shortcut
- Introduce tool and handler for zooming viewport and elements via keyboard shortcut
- Provide tool for an improved implementation for deselecting elements

Part of eclipse-glsp/glsp#1029
holkerveen pushed a commit to holkerveen/glsp-client that referenced this issue Dec 21, 2024
@aylin-sarioglu @holkerveen
#1029 Introduce resizing elements via the keyboard (eclipse-glsp#240)
51fc127 
-  Introduce tool and handler for resizing elements via keyboard shortcut

Part of eclipse-glsp/glsp#1029
holkerveen pushed a commit to holkerveen/glsp-client that referenced this issue Dec 21, 2024
@aylin-sarioglu @holkerveen
#1029 Add documentation for accessibility features (eclipse-glsp#254)
e4e317c 
- Search
- Move
- Zoom
- Resize

Part of eclipse-glsp/glsp#1029
holkerveen pushed a commit to holkerveen/glsp-client that referenced this issue Dec 21, 2024
@aylin-sarioglu @holkerveen
GLSP-1029: Introducing element navigation via keyboard (eclipse-glsp#276
2b90696 
)

-  Introduce tool and handler for element navigation via keyboard shortcut
-  Introduce tool and handler for tracking the current focus of the cursor
-  Introduce tool and handler for the creation of notification/toast
-  Introduce new reposition action for focusing on element without zooming in

Part of eclipse-glsp/glsp#1029
holkerveen pushed a commit to holkerveen/glsp-client that referenced this issue Dec 21, 2024
@aylin-sarioglu @holkerveen
GLSP-1029: Introducing accessible tool palette, node and edge creatio…
d6cf9a8 
…n via keyboard (eclipse-glsp#279)

-  Introduce tool and handler for Grid and Pointer for node creation

-  Introduce tool and handler for edge creation with autocomplete feature

-  Introduce tool and handler zooming via grid

Part of eclipse-glsp/glsp#1029
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
client enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@planger @tortmayr @martin-fleck-at @ndoschek