Generalize 'layoutOptions' to a generic string-object map #26
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6292282 to
8a8bf0d
Compare
In Sprotty layoutOptions can be AbstractLayoutOptions (pre-defined key-value pairs) or ModelLayoutOptions (a generic string to string/number/boolean map). To capture that behavior on the Java side we made the layout options generic but provide GLayoutOptions to capture the set of pre-defined key-value pairs.
8a8bf0d to
b0d2144
Compare
tortmayr
approved these changes
Dec 12, 2019
MatthiasHofstaetter
pushed a commit
to MatthiasHofstaetter/glsp-server
that referenced
this pull request
Dec 21, 2024
…sp#26) In Sprotty layoutOptions can be AbstractLayoutOptions (pre-defined key-value pairs) or ModelLayoutOptions (a generic string to string/number/boolean map). To capture that behavior on the Java side we made the layout options generic but provide GLayoutOptions to capture the set of pre-defined key-value pairs.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In Sprotty layoutOptions can be AbstractLayoutOptions (pre-defined key-value pairs) or ModelLayoutOptions (a generic string to string/number/boolean map). To capture that behavior on the Java side we made the layout options generic but provide GLayoutOptions to capture the set of pre-defined key-value pairs.
Belongs to eclipse-glsp/glsp#8