Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Order of command palette entries can't be controlled from the server #19

Closed
planger opened this issue Dec 2, 2019 · 0 comments · Fixed by #20
Closed

Order of command palette entries can't be controlled from the server #19

planger opened this issue Dec 2, 2019 · 0 comments · Fixed by #20
Labels
bug Something isn't working

Comments

@planger
Copy link
Member

planger commented Dec 2, 2019

Since we are using hash sets, the order of items in the command palette sent from the server to the client is random, which not only prevents the server from defining a certain order, but also lets the order be different everytime the client requests a new set of elements.
@planger planger added the bug Something isn't working label Dec 2, 2019
planger added a commit that referenced this issue Dec 2, 2019
@planger
#19 Use lists instead of sets for command palette and menu items
0596d0e 
This ensures that the order is stable and allows the server to control
the order of elements in the command palette on the client.

Resolves #19
@planger planger mentioned this issue Dec 2, 2019
Merged
planger added a commit to eclipse-glsp/glsp-examples that referenced this issue Dec 2, 2019
@planger
glsp-server#19 Update example according to server API change
9102ebd 
Requires eclipse-glsp/glsp-server#20

eclipse-glsp/glsp-server#19
@planger planger mentioned this issue Dec 2, 2019
Merged
planger added a commit that referenced this issue Dec 2, 2019
@planger
#19 Use lists instead of sets for command palette and menu items
e543eb0 
This ensures that the order is stable and allows the server to control
the order of elements in the command palette on the client.

Resolves #19
planger added a commit that referenced this issue Dec 10, 2019
@planger
#19 Use lists instead of sets for command palette and menu items
cbf56c5 
This ensures that the order is stable and allows the server to control
the order of elements in the command palette on the client.

Resolves #19
tortmayr pushed a commit that referenced this issue Dec 10, 2019
@planger @tortmayr
#19 Use lists instead of sets for command palette and menu items (#20)
099cada 
This ensures that the order is stable and allows the server to control
the order of elements in the command palette on the client.

Resolves #19
planger added a commit to eclipse-glsp/glsp-examples that referenced this issue Dec 10, 2019
@planger
glsp-server#19 Update example according to server API change
f5d4266 
Requires eclipse-glsp/glsp-server#20

eclipse-glsp/glsp-server#19
MatthiasHofstaetter pushed a commit to MatthiasHofstaetter/glsp-server that referenced this issue Dec 21, 2024
@planger @tortmayr
eclipse-glsp#19 Use lists instead of sets for command palette and men…
98671bd 
…u items (eclipse-glsp#20)

This ensures that the order is stable and allows the server to control
the order of elements in the command palette on the client.

Resolves eclipse-glsp#19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

#19 Use lists instead of sets for command palette and menu items eclipse-glsp/glsp-server
1 participant
@planger