Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extend repo script #18

Merged
merged 1 commit into from
Aug 2, 2024
Merged

Extend repo script #18

merged 1 commit into from
Aug 2, 2024

Conversation

tortmayr
Copy link
Contributor

@tortmayr tortmayr commented Jul 24, 2024

What it does

Extend the repo script to

  • Enable checkout/preparation of node and java server repos
  • Add start commands for the node and java repos
  • Update the prepare command to checkout the node server per default
  • Update the log command to only execute the underlying git command if the repo exists
  • Add client subcommand for print the standalone url
  • Add vscode-integration subbcommand for printing the vsix path

Update the playwright config to allow

  • Customization of the default server start command via env variable

Update ci workflow

How to test

Follow-ups

Changelog

  • This PR should be mentioned in the changelog
  • This PR introduces a breaking change (if yes, provide more details below for the changelog and the migration guide)

@tortmayr tortmayr force-pushed the reop-improvements branch 15 times, most recently from 1d3f7d7 to ea7dd00 Compare July 24, 2024 14:30
 Extend the repo script to
- Enable checkout/preparation of node and java server repos
- Add start commands for the node and java repos
- Update the prepare command to checkout the node server per default
- Update the log command to only execute the underlying git command if the repo exists
- Add client subcommand for print the standalone url
-  Add vscode-integration subbcommand for printing the vsix path

Update the playwright config to allow
- Customization of the default server start command via env variable

Update ci workflow
- Also include tests with the java based server
@tortmayr tortmayr force-pushed the reop-improvements branch from ea7dd00 to 6f409d4 Compare August 2, 2024 15:42
@tortmayr tortmayr requested a review from haydar-metin August 2, 2024 15:42
Copy link
Contributor

@haydar-metin haydar-metin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ✨

@tortmayr tortmayr merged commit 635f07d into main Aug 2, 2024
7 checks passed
@tortmayr tortmayr deleted the reop-improvements branch August 2, 2024 16:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants