Support option XMLResource.OPTION_RESOLVE_ENTITIES #11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I did the changes via a PR instead of a direct commit. Does this look okay? |
jukzi
reviewed
Aug 1, 2023
plugins/org.eclipse.emf.ecore.xmi/src/org/eclipse/emf/ecore/xmi/impl/XMLHandler.java
Outdated
Show resolved
Hide resolved
|
It would be good if the commit message contains a documentation how the caller/user can enable old behavior. |
This option is false by default and will prevent XMLHandler.resolveEntity(String, String) from loading external entities. #10
Any developer using EMF will generally understand how to use load options. The user can do nothing... |
|
I think this is done. I will probably want to produce a milestone build and contribute it to the platform and for m2... |
|
I tested the change and confirm eclipse Editor is much faster with this change for files that refer to external entities. |
|
Thanks, Ed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This option is false by default and will prevent XMLHandler.resolveEntity(String, String) from loading external entities.
#10