WsImport.doMain() not closing binding file upon subsequent invocations

[PhilSladen]

Calling WsImport.doMain(new String[] {"-keep", "-Xnocompile", "-p", "genTypesPkg", "-B-npa",
"-d", < path to temp dir>, "-b", < binding file>});

The first time it closes the binding file but upon subsequent invocations it appears to keep the binding file open because it is not possible to delete the file until the JVM is shutdown. Seems to happen with even the simplest WSDL. Binding file contents: < bindings xmlns="https://jakarta.ee/xml/ns/jaxws\">< enableWrapperStyle>false< /enableWrapperStyle>< /bindings>

[lukasj]

version, please. Repro case/test would help too.

[PhilSladen]

3.0.0

[aserkes]

I cannot reproduce the problem. Any additional information (test/case) would be helpful.

[PhilSladen]

package issues;

import java.io.File;
import java.io.FileWriter;
import java.io.IOException;
import java.nio.file.Files;
import java.nio.file.Path;

import org.xml.sax.SAXParseException;

import com.sun.tools.ws.wscompile.WsimportTool;

public class Issue215 {
private static final String TEMP_DIR_PREFIX = "slurpTmp";
private static final String BINDING_FILE_PREFIX = "slurp";
private static final String BINDING_FILE_POSTFIX = "bindingFile.xml";
private static final String TYPES_PKG = "genTypesPkg";

public static void main(String args[]) throws Exception {
	runWsImport();
	runWsImport();
	Thread.sleep(60000); // during this time, unable to delete the 2nd binding file
}

public static void runWsImport() throws Exception {
	Path tmpDir = null;
	File bindingFile = null;
	try {
		tmpDir = Files.createTempDirectory(TEMP_DIR_PREFIX);
		bindingFile = createBindingFile();
		new MyWsImportTool().run(new String[] {"-keep", "-Xnocompile", "-p", TYPES_PKG, "-B-npa",
				"-d", tmpDir.toAbsolutePath().toString(), "-extension", "-b",
				bindingFile.getAbsolutePath(), "simple.wsdl"});
		// Process the Java classes...
	} finally {
		if (tmpDir != null) {
			deleteDirectory(tmpDir.toFile(), true);
		}
		if (bindingFile != null) {
			// TODO: Currently fails on subsequent call to MyWsImportTool().run()
			// Work-around calls cleanUpBindingFiles() upon startup.
			System.out.println("bindingFile=" + bindingFile.getAbsolutePath() + ", delete()=" + bindingFile.delete());
		}
	}
}

// Local version of WsimportTool so that it logs directly to our logger.
//
private static class MyWsImportTool extends WsimportTool {
	public MyWsImportTool() {
		super(System.out);
	}

	public boolean run(String[] args) {
		ImportListener listener = new ImportListener();
		Receiver receiver = new Receiver(listener);
		return super.run(args, listener, receiver);
	}

	private class ImportListener extends Listener {
		@Override
		public void message(String msg) {}
		@Override
		public void error(SAXParseException exception) {
			System.out.println(exception.getMessage());
		}
		@Override
		public void fatalError(SAXParseException exception) {
			System.out.println(exception.getMessage());
		}
		@Override
		public void warning(SAXParseException exception) {
			System.out.println(exception.getMessage());
		}
		@Override
		public void debug(SAXParseException exception) {
			System.out.println(exception.getMessage());
		}
		@Override
		public void info(SAXParseException exception) {
			System.out.println(exception.getMessage());
		}
	}
}

private static File createBindingFile() throws IOException {
	String bindingXml = "<bindings xmlns=\"https://jakarta.ee/xml/ns/jaxws\"><enableWrapperStyle>false</enableWrapperStyle></bindings>";
	File bindingFile = File.createTempFile(BINDING_FILE_PREFIX, BINDING_FILE_POSTFIX);
	FileWriter out = new FileWriter(bindingFile);
	out.write(bindingXml);
	out.close();
	return bindingFile;
}

private static boolean deleteDirectory(File dir, boolean log) {
	for (File file : dir.listFiles()) {
		if (file.isDirectory()) {
			deleteDirectory(file, log);
		} else if (!file.delete()) {
			if (log) {
				System.out.println("Failed to delete " + file);
			}
		}
	}
	boolean success;
	if (!(success=dir.delete())) {
		if (log) {
			System.out.println("Failed to delete " + dir);
		}
	}
	return success;
}

}

[lukasj]

Operating systems do differ in file locking, so I assume this is on Windows. Can you confirm?

[PhilSladen]

Windows 10 Home, 64 bit, OS build 19042.928. I am also attaching contents of "simple.wsdl", referred to in the reproduction code

[PhilSladen]

simple.wsdl.txt

[aserkes]

I checked wscompile and did not find any issue that can cause the problem described in the bug.
I could reproduce the bug only in Windows and if I added to the code System.gc() before bindingFile.delete() the file always was deleted.
So I think the problem is not related to the wscompile.

[lukasj]

can you try 3.0.2-SNAPSHOT and let me know if the issue is gone, please?

[aserkes]

The issue is gone.

[PhilSladen]

Hi Lukas, I would like to check the fix. Is there a link to built binaries for 3.0.2-SNAPSHOT? Thanks,Phil On Friday, 4 June 2021, 13:11:56 BST, Lukas Jungmann ***@***.***> wrote: can you try 3.0.2-SNAPSHOT and let me know if the issue is gone, please? — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub, or unsubscribe.

[lukasj]

3.0.2-SNAPSHOT.zip - under jakarta namespace
2.3.5-SNAPSHOT.zip - under javax namespace

or use https://jakarta.oss.sonatype.org/content/repositories/snapshots repo as shown ie at https://eclipse-ee4j.github.io/mail/#Development_Releases

[PhilSladen]

I tested with jars from the 3.0.2-SNAPSHOT link just provided and the issue appears to have been fixed. Many thanks.

[lukasj]

great, thanks for checking!