Fix NettyInputStream ByteBuf leak #4222
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Please follow the WIKI |
Signed-off-by: Franck Séhédic <franck.sehedic@ledger.fr>
Signed-off-by: Franck Séhédic <franck.sehedic@ledger.fr>
senivam
reviewed
Aug 12, 2019
| @@ -87,6 +87,8 @@ public int read(byte[] b, int off, int len) throws IOException { | |||
|
|
|||
There was a problem hiding this comment.
could you please update copyright year in both files (to 2019) - copyright header at the top of each file?
There was a problem hiding this comment.
thank you for changes, and a question - you are changing method read(byte[] b, int off, int len) but immediately under this method there is method read() without any parameters, but inner logic looks very similar, except the very reading. So, the question - shall InputStream take be closed as well in the read() method?
There was a problem hiding this comment.
Indeed, I refactored the code a bit to avoid this mistake in the future.
Signed-off-by: Franck Séhédic <franck.sehedic@ledger.fr>
Signed-off-by: Franck Séhédic <franck.sehedic@ledger.fr>
Signed-off-by: Franck Séhédic <franck.sehedic@ledger.fr>
jansupol
approved these changes
Aug 13, 2019
senivam
approved these changes
Aug 13, 2019
pa314159
pushed a commit
to pa314159/jersey
that referenced
this pull request
Aug 28, 2019
* Fix NettyInputStream ByteBuf leak in jersey/netty HTTP2 Handler Signed-off-by: Franck Séhédic <franck.sehedic@ledger.fr>
This was referenced Jun 26, 2021
This was referenced Aug 5, 2021
This was referenced Sep 5, 2021
1 task
This was referenced Oct 21, 2021
Closed
Closed
1 task
This was referenced Mar 7, 2022
This was referenced Mar 15, 2022
This was referenced Apr 17, 2022
This was referenced May 3, 2022
1 task
1 task
1 task
1 task
1 task
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If not closed here
takegoes unreferenced leading to a leak of the underlying ByteBuf.LEAK: ByteBuf.release() was not called before it's garbage-collected. See http://netty.io/wiki/reference-counted-objects.html for more information.