Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#1677: Add/implement JVar.annotate(JAnnotationUse annotation) #1689

Merged
merged 1 commit into from
Jan 24, 2023
Merged

#1677: Add/implement JVar.annotate(JAnnotationUse annotation) #1689

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 9 additions & 2 deletions jaxb-ri/codemodel/codemodel/src/main/java/com/sun/codemodel/JVar.java
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
/*
* Copyright (c) 1997, 2021 Oracle and/or its affiliates. All rights reserved.
* Copyright (c) 1997, 2023 Oracle and/or its affiliates. All rights reserved.
*
* This program and the accompanying materials are made available under the
* terms of the Eclipse Distribution License v. 1.0, which is available at
Expand Down Expand Up @@ -149,6 +149,13 @@ public JAnnotationUse annotate(JClass clazz){
return a;
}

public void annotate(JAnnotationUse annotation) {
if (annotations == null)
annotations = new ArrayList<>();

annotations.add(annotation);
}

/**
* Adds an annotation to this variable.
*
Expand Down Expand Up @@ -178,7 +185,7 @@ public Collection<JAnnotationUse> annotations() {
}

protected boolean isAnnotated() {
return annotations!=null;
return annotations != null && !annotations.isEmpty();
}

public void bind(JFormatter f) {
Expand Down
3 changes: 3 additions & 0 deletions jaxb-ri/docs/release-documentation/src/docbook/jaxb-changelog.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,6 +36,9 @@
<listitem><para>
<link xlink:href="https://github.com/eclipse-ee4j/jaxb-ri/issues/1676">#1676</link>: Impossible to build with non-english system
</para></listitem>
<listitem><para>
<link xlink:href="https://github.com/eclipse-ee4j/jaxb-ri/issues/1677">#1677</link>: Add/implement JVar.annotate(JAnnotationUse annotation)
</para></listitem>
<listitem><para>
<link xlink:href="https://github.com/eclipse-ee4j/jaxb-ri/issues/1680">#1680</link>: Avoid eager initialization of Scope objects.
</para></listitem>
Expand Down