Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Message catalog key not transformed: using.default.ds #23873

Closed
mheydem opened this issue Mar 29, 2022 · 5 comments · Fixed by #24045
Closed

Message catalog key not transformed: using.default.ds #23873

mheydem opened this issue Mar 29, 2022 · 5 comments · Fixed by #24045
Assignees
Milestone

Comments

@mheydem
Copy link

mheydem commented Mar 29, 2022

Environment Details

  • GlassFish Version (and build number): Glassfish 6.0 Release
  • JDK version: corretto jdk1.8.0_322
  • OS: Windows 10

Problem Description

This message appears in my server.log:

[2022-03-29T13:06:44.563+0000] [glassfish 6.0] [WARNING] [] [javax.enterprise.resource.resourceadapter.org.glassfish.jdbcruntime] [tid: _ThreadID=33 _ThreadName=RunLevelControllerThread-1648559203407] [timeMillis: 1648559204563] [levelValue: 900] [[
  using.default.ds]]

A more meaningful text like this is expected:
RAR8068: Using default datasource : {0} for pool : {1}

This issue was fixed for Payara. Glassfish could have this fix, too.
payara/Payara#502

Steps to reproduce

Not sure. I guess using a jdbc resource adapter can trigger this.

Impact of Issue

This issue does not to hurt functionality, but animates developers to waste time on useless investigation.

@arjantijms
Copy link
Contributor

@dmatej as that was your original work back then, would you like to look at this again?

@mheydem
Copy link
Author

mheydem commented Mar 30, 2022

I was able to narrow down the problem.
It occurs in connection with a custom AuditModule.
I think the fix or this particular constellation is not of public interest.
That is why I am closing this bug report. Thank you for your help.
If I find something interesting, I will share it with you.

@mheydem mheydem closed this as completed Mar 30, 2022
@dmatej dmatej reopened this Mar 30, 2022
@dmatej
Copy link
Contributor

dmatej commented Mar 30, 2022

Ok, it is in my list in GF too :)

@dmatej dmatej added this to the 6.2.6 milestone Mar 30, 2022
@dmatej dmatej self-assigned this Mar 30, 2022
@mheydem
Copy link
Author

mheydem commented Mar 31, 2022

I was able to reproduce this by extending domain.xml of the default domain1:

  • adding a <jdbc-connection-pool res-type="javax.sql.XADataSource" datasource-classname="oracle.jdbc.xa.client.OracleXADataSource" name="OracleConnectionPool">
  • adding a <jdbc-resource pool-name="OracleConnectionPool" jndi-name="jdbc/oracle">
  • adding an application(or custom audit module) which accesses the jdbc-resource via jndi
  • make sure the oracle libs are NOT provided to glassfish (for example ojdbc8.jar)

@dmatej Can you create the symptoms in the same way?

@dmatej
Copy link
Contributor

dmatej commented Mar 31, 2022

I remember it was depending on the classloader and when Sun+Oracle started refactoring for GF3, they sometimes forgot to move the line, sometimes they did not notice that resources depend on the CL used, so once it works, when using app CL, it doesn't.
I fixed that by some refactoring, where I added method to LogDomains and moved some things around. Maybe I will have some time tomorrow and I will do that in GlassFish again.

@dmatej dmatej modified the milestones: 6.2.6, 7.0.0 Jul 12, 2022
dmatej added a commit to dmatej/glassfish that referenced this issue Jul 15, 2022
dmatej added a commit to dmatej/glassfish that referenced this issue Jul 15, 2022
- created IIOPImplLogFacade
- some missing keys were found in logs, some were found in sources
- CULoggerInfo contained commented out code - some keys were used on other places
dmatej added a commit to dmatej/glassfish that referenced this issue Jul 15, 2022
- just message keys I have seen in logs, tested manually
@dmatej dmatej mentioned this issue Jul 15, 2022
dmatej added a commit to dmatej/glassfish that referenced this issue Jul 16, 2022
dmatej added a commit to dmatej/glassfish that referenced this issue Jul 16, 2022
…dles

- for some unknown reason tests fail when we use standard of JDK8+ for
  setting a resource bundle to a logger. I couldn't find the exact cause
  of the failure (invalid tx state) now, but I will get back to it later
  after jta/jps refactoring and also with new logging it should be easier.
  That is why I added the FIXME here - and also to prevent me or someone
  else breaking it again.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants