Bugfix: check to determine if asset can be deleted #1408
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR changes/adds
This PR adds a method to the
ContractNegotiationStore
that returns allContractNegotiation
s that have aContractAgreement
which references a particular asset in order to check, whether the asset can be deleted or not.Why it does that
Deleting Assets should be forbidden once it is referenced by a
ContractAgreement
. Previously the check used a filter expression, which is not (yet) implemented for SQL.Further notes
ReflectionUtil
threw a NPE when recursively resolving a field, who's parent is null, e.g.ContractNegotiation -> contractAgreement -> assetId
whencontractAgreement
is null.Linked Issue(s)
Closes #1403
Checklist
no-changelog
)