Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to use iceoryx 2.0 #225

Merged
merged 2 commits into from
Mar 11, 2022

Conversation

sumanth-nirmal
Copy link
Contributor

@sumanth-nirmal sumanth-nirmal commented Mar 4, 2022

Fixes #224

This should be merged after eclipse-cyclonedds/cyclonedds#1175

@@ -88,7 +88,7 @@ steps:
set -e -x
sudo apt-get install libacl1-dev libncurses5-dev pkg-config
git clone --depth 1 \
--branch "${ICEORYX_BRANCH:-v1.0.1}" \
--branch "${ICEORYX_BRANCH:-v1.90.0}" \
Copy link
Contributor

@MatthiasKillat MatthiasKillat Mar 7, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This iceoryx tag will probably not work with https://github.com/eclipse-cyclonedds/cyclonedds/pull/1175/files since the storage is not used anymore...

I.e. it will not work with iceoryx master (2.0) and 1.x at the same time.

@sumanth-nirmal sumanth-nirmal force-pushed the update_to_use_iceoryx_2_0 branch from 445b6cc to 73448f2 Compare March 7, 2022 21:21
Signed-off-by: Sumanth Nirmal <sumanth.724@gmail.com>
Signed-off-by: Sumanth Nirmal <sumanth.724@gmail.com>
@sumanth-nirmal sumanth-nirmal force-pushed the update_to_use_iceoryx_2_0 branch from 73448f2 to 9c8351b Compare March 11, 2022 06:20
Copy link
Contributor

@eboasson eboasson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@eboasson eboasson merged commit 150985e into eclipse-cyclonedds:master Mar 11, 2022
@sumanth-nirmal sumanth-nirmal deleted the update_to_use_iceoryx_2_0 branch March 11, 2022 19:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update cyclonedds-cxx to be compatible with iceoryx2.0
3 participants