Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[cdt_11_6] Add enabled to JSON Compilation Database Generator prop page (#847) (#848) #850

Merged
merged 2 commits into from
Jun 28, 2024
Merged

[cdt_11_6] Add enabled to JSON Compilation Database Generator prop page (#847) (#848) #850

merged 2 commits into from
Jun 28, 2024

Conversation

github-actions[bot]
Copy link

Backport

This will backport the following commits from main to cdt_11_6:

Questions ?

Please refer to the Backport tool documentation

@ghentschke
Add enabled to JSON Compilation Database Generator prop page (#847) (#…
91c4a6f 
…848)

Show the JSON Compilation Database Generator properties page only for
managed build projects.

fixes #847

(cherry picked from commit 597eda2)
@github-actions github-actions bot mentioned this pull request Jun 28, 2024
Merged
@github-actions GitHub Actions
Copy link
Author

Test Results

   600 files     600 suites   13m 4s ⏱️
10 193 tests 10 170 ✅ 23 💤 0 ❌
10 231 runs  10 208 ✅ 23 💤 0 ❌

Results for commit ceaed3f.

@jonahgraham jonahgraham added this to the 11.6.1 milestone Jun 28, 2024
@jonahgraham jonahgraham linked an issue Jun 28, 2024 that may be closed by this pull request
JSON Compilation Database Generator properties page is visible in non C/C++ projects #847
Closed
@jonahgraham
Copy link
Member

Test Results

   600 files     600 suites   13m 4s ⏱️ 10 193 tests 10 170 ✅ 23 💤 0 ❌ 10 231 runs  10 208 ✅ 23 💤 0 ❌

Results for commit ceaed3f.

These result comments disappeared a while ago, now they have come back?

@jonahgraham jonahgraham merged commit 54e9f2f into cdt_11_6 Jun 28, 2024
6 checks passed
@jonahgraham jonahgraham deleted the backport/cdt_11_6/pr-848 branch June 28, 2024 23:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonahgraham jonahgraham jonahgraham approved these changes

Assignees

@ghentschke ghentschke

Labels
None yet
Projects
None yet
Milestone
11.6.1
Development

Successfully merging this pull request may close these issues.

JSON Compilation Database Generator properties page is visible in non C/C++ projects
2 participants
@jonahgraham @ghentschke