Use CDT's container to run all code cleanliness checks #845
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We need a new docker container for GitHub that runs as the same uid that GitHub actions uses so permissions all work correctly.
|
The big difference is that we are using CDT's own docker containers pulled from quay.io - same as what we do in the Jenkinsfile. We haven't had rate limiting problems doing this for Jenkins on Eclipse Foundation machines, but I don't know if we can run afoul of quay.io rate limiting running like this. If we do, I guess we can roll back this change (just the |
💚 All backports created successfully
Questions ?Please refer to the Backport tool documentation |
1 similar comment
💚 All backports created successfully
Questions ?Please refer to the Backport tool documentation |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This aims to avoid a repeat of what needed fixing in #843 by ensuring all code cleanliness checks are run with GitHub actions.