Speed up closing all file descriptors in the child process (Fixes #835) #840
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I tested it successfully under linux x86_64 with eclipse 2024-06. |
…ipse-cdt#835) When _SC_OPEN_MAX (max nr of open files limit per process) is a very big number, then closing all possible file handles can take a while. This change first tries to use the syscall close_range() if available, falling back to use /proc/self/fd to close only open file handles, and lastly falling back to the old way of closing all possible handles one after another. In general, the first or second approach should be available which speeds up the pty spawning. Refs JetBrains/pty4j#147 Copied from JetBrains/pty4j@04685d8 (which is EPL 1.0) Co-authored-by: Sergey Simonchik <sergey.simonchik@jetbrains.com>
adef8eb to
23af0ec
Compare
jonahgraham
added a commit
to jonahgraham/cdt
that referenced
this pull request
Jun 23, 2024
Apply the coding standards to the C code from eclipse-cdt#840
jonahgraham
added a commit
that referenced
this pull request
Jun 23, 2024
Apply the coding standards to the C code from #840
jonahgraham
pushed a commit
to jonahgraham/cdt
that referenced
this pull request
Jun 27, 2024
…ipse-cdt#835) _This commit adds to eclipse-cdt#840 7bd8d52 to apply the same fix to another place that does the same operation on all fds._ When _SC_OPEN_MAX (max nr of open files limit per process) is a very big number, then closing all possible file handles can take a while. This change first tries to use the syscall close_range() if available, falling back to use /proc/self/fd to close only open file handles, and lastly falling back to the old way of closing all possible handles one after another. In general, the first or second approach should be available which speeds up the pty spawning. Refs JetBrains/pty4j#147 Copied from JetBrains/pty4j@04685d8 (which is EPL 1.0) Co-authored-by: Sergey Simonchik <sergey.simonchik@jetbrains.com>
jonahgraham
pushed a commit
that referenced
this pull request
Jun 28, 2024
_This commit adds to #840 7bd8d52 to apply the same fix to another place that does the same operation on all fds._ When _SC_OPEN_MAX (max nr of open files limit per process) is a very big number, then closing all possible file handles can take a while. This change first tries to use the syscall close_range() if available, falling back to use /proc/self/fd to close only open file handles, and lastly falling back to the old way of closing all possible handles one after another. In general, the first or second approach should be available which speeds up the pty spawning. Refs JetBrains/pty4j#147 Copied from JetBrains/pty4j@04685d8 (which is EPL 1.0) Co-authored-by: Sergey Simonchik <sergey.simonchik@jetbrains.com>
💚 All backports created successfully
Questions ?Please refer to the Backport tool documentation |
jonahgraham
added a commit
to jonahgraham/cdt
that referenced
this pull request
Jun 28, 2024
Apply the coding standards to the C code from eclipse-cdt#840 (cherry picked from commit 24d9bd1)
jonahgraham
pushed a commit
to jonahgraham/cdt
that referenced
this pull request
Jun 28, 2024
…ipse-cdt#835) _This commit adds to eclipse-cdt#840 7bd8d52 to apply the same fix to another place that does the same operation on all fds._ When _SC_OPEN_MAX (max nr of open files limit per process) is a very big number, then closing all possible file handles can take a while. This change first tries to use the syscall close_range() if available, falling back to use /proc/self/fd to close only open file handles, and lastly falling back to the old way of closing all possible handles one after another. In general, the first or second approach should be available which speeds up the pty spawning. Refs JetBrains/pty4j#147 Copied from JetBrains/pty4j@04685d8 (which is EPL 1.0) Co-authored-by: Sergey Simonchik <sergey.simonchik@jetbrains.com> (cherry picked from commit 3875408)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When _SC_OPEN_MAX (max nr of open files limit per process) is a very big number, then closing all possible file handles can take a while. This change first tries to use the syscall close_range() if available, falling back to use /proc/self/fd to close only open file handles, and lastly falling back to the old way of closing all possible handles one after another.
In general, the first or second approach should be available which speeds up the pty spawning.
Refs JetBrains/pty4j#147
Copied from JetBrains/pty4j@04685d8 (which is EPL 1.0)
Fixes #835