Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update gson to 2.11.0 #798

Merged
merged 1 commit into from
May 22, 2024
Merged

Update gson to 2.11.0 #798

merged 1 commit into from
May 22, 2024

Conversation

merks
Copy link
Contributor

@merks merks commented May 21, 2024

No description provided.

@jonahgraham jonahgraham self-requested a review May 21, 2024 16:33
@jonahgraham
Copy link
Member

I'm just working on the M3 contribution - I'll see if I can get this in. However the reason that some dependencies are tight on version range is because in the past gson have changed API in a breaking way without a major version bump. Have you run something like japicmp on 2.10 and 2.11? If not, I will do that as part of this release.

However as LSP4J is much more sensitive to gson versions, I will do it there first - see eclipse-lsp4j/lsp4j#836

@merks
Copy link
Contributor Author

merks commented May 21, 2024

I don’t have the capacity to test orbit bundles.

I just enhanced the orbit maven generator so that it updates the file in a local git repository so I can more easily create a PR.

Other projects like the Platform have already updated.

@jonahgraham
Copy link
Member

I don’t have the capacity to test orbit bundles.

:-) Didn't expect you to - just making sure I wasn't repeating work

I just enhanced the orbit maven generator so that it updates the file in a local git repository so I can more easily create a PR.

Awesome - next step will be a bot :-)

Other projects like the Platform have already updated.

I think CDT will be fine, but I don't think newer LSP4J will end up in SimRel without eclipse-lsp4j/lsp4j#836

@jonahgraham jonahgraham merged commit eeb4f03 into eclipse-cdt:main May 22, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants