Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

make the cmake error parser public API #72

Merged
merged 1 commit into from
Sep 14, 2022
Merged

make the cmake error parser public API #72

merged 1 commit into from
Sep 14, 2022

Conversation

15knots
Copy link
Contributor

@15knots 15knots commented Sep 13, 2022

Signed-off-by: Martin Weber 11367029+15knots@users.noreply.github.com

@15knots
make the cmake error parser public API
3d62e16 
Change-Id: I2ab5d659e01ace32dbd61ffada18e2f8f47bc5cf
Signed-off-by: Martin Weber <11367029+15knots@users.noreply.github.com>
@15knots 15knots requested a review from jonahgraham September 13, 2022 18:22
@15knots 15knots added this to the 11.0.0 milestone Sep 13, 2022
jonahgraham
jonahgraham approved these changes Sep 13, 2022
View reviewed changes
Copy link
Member

@jonahgraham jonahgraham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR looks a bit cleaner and won't need to be squashed. Thanks for recreating it.

@jonahgraham jonahgraham added the noteworthy Pull requests and fixed issues that should be highlighted to users label Sep 14, 2022
@15knots
Copy link
Contributor Author

15knots commented Sep 14, 2022

test failures do not come from changes in this PR.

@15knots 15knots merged commit 9c8986b into eclipse-cdt:main Sep 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonahgraham jonahgraham jonahgraham approved these changes

Assignees
No one assigned
Labels
noteworthy Pull requests and fixed issues that should be highlighted to users
Projects
None yet
Milestone
11.0.0
Development

Successfully merging this pull request may close these issues.
2 participants
@15knots @jonahgraham