Fix some flaky managedbuilder tests #54
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Don't sleep for a hardcoded time but wait for the actual condition. 1000 ms was often insufficient on my system.
testAbstractBuiltinSpecsDetector_EnvChangesGlobal did not properly clean up after itself, which caused testAbstractBuiltinSpecsDetector_EnvChangesConfiguration_1, testAbstractBuiltinSpecsDetector_EnvChangesConfiguration_2, and testAbstractBuiltinSpecsDetector_EnvChangesGlobal to fail when run for the second time in the same session. Running tests twice is not useful, but happens in Eclipse with a launch configuration set to run all tests in org.eclipse.cdt.managedbuilder.core.tests/tests - once directly and once through AllLanguageSettingsProvidersMBSTestSuite. I have not found any way of running every test exactly once in the GUI.
jonahgraham
approved these changes
Aug 22, 2022
|
Thanks @cwalther for fixing some of these tests.
I think this is out of date now - the suites are still in there but we now run (most) tests using the standard patterns in Tycho Surefire. Some of the bundles have exceptions like this one: cdt/core/org.eclipse.cdt.core.tests/pom.xml Lines 57 to 64 in 0158c6a I'll try an update to the readme. |
jonahgraham
added a commit
to jonahgraham/cdt
that referenced
this pull request
Aug 22, 2022
as a result of the conversation on PR eclipse-cdt#54 we identified the FAQ on this item was out of date. eclipse-cdt#54 (comment)
jonahgraham
added a commit
to jonahgraham/cdt
that referenced
this pull request
Aug 22, 2022
as a result of the conversation on PR eclipse-cdt#54 we identified the FAQ on this item was out of date. eclipse-cdt#54 (comment)
jonahgraham
added a commit
that referenced
this pull request
Aug 22, 2022
as a result of the conversation on PR #54 we identified the FAQ on this item was out of date. #54 (comment)
|
Thanks! This is working much more conveniently than Bugzilla+Gerrit. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes some tests that sometimes fail for me when I run them in the Eclipse GUI on Linux.
CProjectDescriptionSerializationTests.testPersistentProperties contained a hardcoded sleep time to wait for an asynchronous operation that was often insufficient. Wait for the actual condition instead.
BuiltinSpecsDetectorTest.testAbstractBuiltinSpecsDetector_EnvChangesGlobal did not properly clean up after itself, which caused it, and some of its siblings, to fail when run for the second time in the same session.
(Running tests twice in the same session is not done deliberately, but it happens in Eclipse with a JUnit Plug-in Test launch configuration set to run all tests in org.eclipse.cdt.managedbuilder.core.tests/tests – once directly and once through AllLanguageSettingsProvidersMBSTestSuite. I have not found any way of running every test exactly once in the GUI – the recommended way seems to be to select org.eclipse.cdt.managedbuilder.tests.suite.AutomatedIntegrationSuite, but that leaves out some tests.)