Add support for Context when running Boost test runners #507
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The pre-existing code assumed that string (qName) passed in to start and end element was always interned and compared those strings to constants using ==. Instead rewrite code using switch statements on the strings. Also includes small change to the exception handling so that code analysis can correctly where exceptions are always thrown. i.e. instead of hiding a throw in an always throwing method, return the exception and throw it at the call site.
The code for boost test running parsing left all the excess whitespace from the XML file. This led to a lot whitespace in messages in the UI. This change trims leading and trailing whitespace, but preserves whitespace within a message.
Boost a while ago added Context tags, this commit makes those context tags supported in the testsrunner code of CDT See also https://www.boost.org/doc/libs/1_82_0/libs/test/doc/html/boost_test/test_output/test_tools_support_for_logging/contexts.html Fixes 459
cc21cc8 to
f59c109
Compare
|
Setting to draft until discussion in #459 is progressed/concluded. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #459