Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix meson build under Docker Tooling #491

Merged
merged 2 commits into from
Aug 10, 2023
Merged

Fix meson build under Docker Tooling #491

merged 2 commits into from
Aug 10, 2023

Conversation

jjohnstn
Copy link
Contributor

@jjohnstn jjohnstn commented Aug 4, 2023

  • add new IToolChainConstants containing SECURITY_OPTS constant
  • add new setLauncher() method to CBuildConfiguration so that watchProcess() can be used for container building
  • enhance ContainerCommandLauncher to discover specification of security opts for execute() so "seccomp=undefined" can be specified
  • fix ContainerCommandLauncherFactory.verifyIncludePaths() to only look at filtered includes that have been made absolute and to recognize matches when the prefix shows up in the loaded list
  • add setting a property to ContainerGCCToolChain to set security opts and default to "seccomp=undefined"
  • when generating scannerinfo, specify "seccomp=undefined"
  • in ContainerGCCToolChain.startBuildProcess() remove extraneous banner statement and ensure that the build directory is created
  • fixes Meson project does not build in Docker container #479

@jjohnstn
Fix meson build under Docker Tooling
1eecbfb 
- add new IToolChainConstants containing SECURITY_OPTS constant
- add new setLauncher() method to CBuildConfiguration so that
  watchProcess() can be used for container building
- enhance ContainerCommandLauncher to discover specification of
  security opts for execute() so "seccomp=undefined" can be specified
- fix ContainerCommandLauncherFactory.verifyIncludePaths() to only
  look at filtered includes that have been made absolute and to
  recognize matches when the prefix shows up in the loaded list
- add setting a property to ContainerGCCToolChain to set security opts
  and default to "seccomp=undefined"
- when generating scannerinfo, specify "seccomp=undefined"
- in ContainerGCCToolChain.startBuildProcess() remove extraneous
  banner statement and ensure that the build directory is created
- fixes eclipse-cdt#479
@jjohnstn jjohnstn self-assigned this Aug 4, 2023
@jjohnstn jjohnstn added the build Build components of CDT, anything to do with running the compiler, using Make, CMake, or any builder label Aug 4, 2023
@jjohnstn jjohnstn merged commit dd4a40a into eclipse-cdt:main Aug 10, 2023
@jjohnstn jjohnstn deleted the mesonfix branch August 10, 2023 20:36
jonahgraham added a commit to jonahgraham/cdt that referenced this pull request Aug 15, 2023
@jonahgraham
Fixup some API version errors
edbf991 
Follow up for eclipse-cdt#491
@jonahgraham jonahgraham mentioned this pull request Aug 15, 2023
Merged
jonahgraham added a commit that referenced this pull request Aug 16, 2023
@jonahgraham
Fixup some API version errors
220ba61 
Follow up for #491
@jonahgraham jonahgraham added this to the 11.3.0 milestone Sep 13, 2023
@jonahgraham jonahgraham added the noteworthy Pull requests and fixed issues that should be highlighted to users label Sep 13, 2023
davmac314 pushed a commit to davmac314/cdt that referenced this pull request Sep 24, 2023
@jjohnstn @davmac314
Fix meson build under Docker Tooling (eclipse-cdt#491)
3efb57e 
* Fix meson build under Docker Tooling

- add new IToolChainConstants containing SECCOMP_UNCONFINED property constant
- add new setLauncher() method to CBuildConfiguration so that
  watchProcess() can be used for container building
- enhance ContainerCommandLauncher to discover specification of
  SECCOMP_UNDEFINED boolean option for execute() so "seccomp=undefined" can be specified
- fix ContainerCommandLauncherFactory.verifyIncludePaths() to only
  look at filtered includes that have been made absolute and to
  recognize matches when the prefix shows up in the loaded list
- add setting a property to ContainerGCCToolChain to set SECCOMP_UNCONFINED to true
  by default for the time-being
- when generating scannerinfo, specify "seccomp=unconfined"
- in ContainerGCCToolChain.startBuildProcess() remove extraneous
  banner statement and ensure that the build directory is created
- fixes eclipse-cdt#479
davmac314 pushed a commit to davmac314/cdt that referenced this pull request Sep 24, 2023
@jonahgraham @davmac314
Fixup some API version errors
8fd7833 
Follow up for eclipse-cdt#491
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@jjohnstn jjohnstn

Labels
build Build components of CDT, anything to do with running the compiler, using Make, CMake, or any builder noteworthy Pull requests and fixed issues that should be highlighted to users
Projects
None yet
Milestone
11.3.0
Development

Successfully merging this pull request may close these issues.

Meson project does not build in Docker container
2 participants
@jjohnstn @jonahgraham