Docker: Allow setting a mapping for docker paths #46
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bug 579944 introduced using Windows paths, to allow putting your project into the WSL's file system. While Docker for Windows (the commercial version) supports Windows paths, this does not work with a OSS-docker installed in the WSL. It is now possible to provide a path mapping to work around this.
jjohnstn
reviewed
Aug 29, 2022
...e.cdt.docker.launcher/src/org/eclipse/cdt/internal/docker/launcher/ContainerPropertyTab.java
Show resolved
Hide resolved
jjohnstn
approved these changes
Aug 29, 2022
Change-Id: I61ff533fb496e19dbcd187a8f7ce60a6face599e
|
These tests are in unrelated plugins so ignore if you want this in 2022-09 release. |
BTW Current Main branch is for 2022-12 release. For 2022-09 we have already released 10.7.1 - of course we can do a 10.7.2 if we want to backport things. Please let me know. |
|
I didn't know that 11.0.0 wasn't 2022-09. The fix can't be back-ported as it does a major version bump in a plug-in so needs to be part of 11.0.0. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bug 579944 introduced using Windows paths, to allow putting your project into the WSL's file system.
While Docker for Windows (the commercial version) supports Windows paths, this does not work with a OSS-docker installed in the WSL.
[See discussion in Bug 579944]] (https://bugs.eclipse.org/bugs/show_bug.cgi?id=579944#c5)
It is now possible to provide a path mapping to work around this.