-
Notifications
You must be signed in to change notification settings - Fork 207
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Simplify the API baseline target #42
Conversation
Guys, I submitted the changes as PR. Then I can see how the API baseline is used in the build and you can more easily review this in your local workspace... |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I greet this change as it reduces support effort. Only one minor comment
<unit id="org.eclipse.tm.terminal.connector.cdtserial.feature.feature.group" version="0.0.0"/> | ||
<unit id="org.eclipse.tm.terminal.connector.remote.feature.feature.group" version="0.0.0"/> | ||
<unit id="org.eclipse.tm.terminal.feature.feature.group" version="0.0.0"/> | ||
<repository location="https://download.eclipse.org/tools/cdt/releases/latest"/> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Usually we have repository at the top and then we sort locations by repository::location
I kind of doubt the test failures can be caused the API baseline change... Now that I look closely, I don't think the baseline target is even used. The actual Maven build uses this which is out of date too:
|
8c9049b
to
e5d53cf
Compare
Also simplify the corresponding API baseline targlet in the setup eclipse-cdt#39
e5d53cf
to
aab5f74
Compare
Given the cdt-baseline.target is not used in the build, but rather is only used for a manual setup, reducing maintenance effort would definitely be a good thing... |
That is the compare and replace repo. Separate from api baseline. As mentioned in the other comment I just made that eclipse-cdt/cdt-infra#59 needs to be done for next version and currently main hasn’t been prepped for post 10.7 yet. BTW main branch will be 11.0 next, that is a major release of CDT is upcoming. |
I’m glad that you (Ed) are simplifying and that Alexander has time to review these changes. I will happily review anything left to review later. |
Also simplify the corresponding API baseline targlet in the setup
#39