Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add GNU PE64 binary parser for MinGW GCC toolchain #365

Merged
merged 1 commit into from
Apr 13, 2023
Merged

Add GNU PE64 binary parser for MinGW GCC toolchain #365

merged 1 commit into from
Apr 13, 2023

Conversation

jld01
Copy link
Contributor

@jld01 jld01 commented Apr 13, 2023

Part of #361

@jld01 jld01 added this to the 11.2.0 milestone Apr 13, 2023
@jld01
Copy link
Contributor Author

jld01 commented Apr 13, 2023

This PR introduces a new GNU PE64 parser for use with the MinGW GCC toolchain. It allows the user to double click on a MinGW executable and invoke objdump if present on the global PATH.

@jld01 jld01 force-pushed the gnu-pe64-parser branch from 23f0764 to 8e86135 Compare April 13, 2023 20:20
Torbjorn-Svensson
Torbjorn-Svensson approved these changes Apr 13, 2023
View reviewed changes
Copy link
Member

@Torbjorn-Svensson Torbjorn-Svensson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have not run the code, but based on visual review, I think this is fine.
Thank you John for working on this!

@jld01
Copy link
Contributor Author

jld01 commented Apr 13, 2023

I have not run the code, but based on visual review, I think this is fine. Thank you John for working on this!

Thank you for the review, @Torbjorn-Svensson. I will merge this and move on to per-config environment setup.

@jld01 jld01 merged commit 45a6e79 into eclipse-cdt:main Apr 13, 2023
@jld01 jld01 deleted the gnu-pe64-parser branch April 28, 2023 19:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Torbjorn-Svensson Torbjorn-Svensson Torbjorn-Svensson approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
11.2.0
Development

Successfully merging this pull request may close these issues.
2 participants
@jld01 @Torbjorn-Svensson