-
Notifications
You must be signed in to change notification settings - Fork 207
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add c++20 character types #342
Add c++20 character types #342
Conversation
d813935
to
256dbe8
Compare
256dbe8
to
9981882
Compare
3908f25
to
bef1b91
Compare
The build on this is failing, best guess is some inlined constant or change of used internals from cdt core has changed causing the failure:
It would be nice to know why it has changed, but either way, the version of org.eclipse.cdt.ui needs to be bumped. |
Hi @jonahgraham either I bumped the wrong piece in 4411c45 or it did not helped here. |
4411c45
to
ad126ce
Compare
Weird goingson now. The current code passes code cleanliness without the bump, so not sure what is going on and I won't spend much time on that. I will review this later. |
Well there actually was a bump in Navigator cleanup 47275c3 |
Thanks for figuring out what happened. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This LGTM. All the changes made seem good. There is still the possibility that some other areas need modification, but I don't have the knowledge to know what may be missing here.
I will make the small change mentioned and submit today for M1.
...se.cdt.core/parser/org/eclipse/cdt/internal/core/dom/parser/cpp/CPPASTLiteralExpression.java
Show resolved
Hide resolved
ad126ce
to
d6c61e9
Compare
This change adds
char8_t
character type from c++20