Fix c++17 fold expression in variable template specialization #305
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
40825f1 to
4f662e2
Compare
|
LGTM. I have kicked off the builds again as they failed for unrelated reasons. |
|
It looks like a Maven 3.8.7 vs 3.9.0 version. GitHub actions just changed to the recently released Maven 3.9.0. Follow along on my journey in #308 |
|
Please rebase/merge this change with main to pick up the fix to #309 |
4f662e2 to
83bfe82
Compare
|
Thanks @jonahgraham that worked to resolve CI issue. |
83bfe82 to
3da16bd
Compare
|
I have rebased the change to make sure that it builds cleanly on main now that we released 11.1.0. Normally this is just a check that code cleanliness still passes, especially bundle version numbers are where they are supposed to be. |
|
Thank you @i-garrison. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change fixes an issue where variable template specialization requires calculating a fold over predicates from parameter pack. Added a couple of tests showing this common pattern in libstdc++-v3.