Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New API to custom parse #define lines from GCC during scanning #286

Merged
merged 1 commit into from
Feb 15, 2023
Merged

New API to custom parse #define lines from GCC during scanning #286

merged 1 commit into from
Feb 15, 2023

Conversation

ewaterlander
Copy link
Contributor

@ewaterlander ewaterlander commented Feb 15, 2023 •
edited by jonahgraham
Loading

Option to override the matching of macro defines for the Core Build GCC toolchain. This may be needed for custom compilers

@github-actions
Copy link

github-actions bot commented Feb 15, 2023 •
edited
Loading

Test Results

   540 files     540 suites   16m 9s ⏱️
9 652 tests 9 630 ✔️ 22 💤 0 ❌
9 663 runs  9 641 ✔️ 22 💤 0 ❌

Results for commit f17c77b.

♻️ This comment has been updated with latest results.

@ewaterlander @jonahgraham
New API to custom parse #define lines from GCC during scanning
f17c77b 
Option to override the matching of macro defines for the Core Build
GCC toolchain. This may be needed for custom compilers.

Also-by: Jonah Graham <jonah@kichwacoders.com>
@jonahgraham
Copy link
Member

@ewaterlander the idea of this looks fine to me, but as this adds new API I think it is important to have the API be a bit cleaner and avoid passing mutable objects into the method.

Rather than try to explain what I think is needed I tried to draft something up. Please look at this change and let me know what you think. Does this work for you?

If you needed the mutable symbols passed to the subclass, then my change breaks it. But if you need that, can you please explain why?

@ewaterlander
Copy link
Contributor Author

Hi Jonah,

Thanks for making it cleaner. I don't need the mutable symbols. It looks good to me, and works for me.

regards,

Erwin

@jonahgraham jonahgraham merged commit 920f7d8 into eclipse-cdt:main Feb 15, 2023
@jonahgraham jonahgraham changed the title Option to override the matching of macro defines for the Core Build GCC New API to custom parse #define lines from GCC during scanning Feb 15, 2023
@jonahgraham jonahgraham added the build Build components of CDT, anything to do with running the compiler, using Make, CMake, or any builder label Feb 15, 2023
@jonahgraham jonahgraham added this to the 11.1.0 milestone Feb 15, 2023
@jonahgraham jonahgraham added editor The CDT C/C++, Assembly, Makefile and other editors provided by CDT noteworthy Pull requests and fixed issues that should be highlighted to users language C/C++ Language Support labels Feb 15, 2023
@ewaterlander ewaterlander deleted the match_define branch March 16, 2023 16:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
build Build components of CDT, anything to do with running the compiler, using Make, CMake, or any builder editor The CDT C/C++, Assembly, Makefile and other editors provided by CDT language C/C++ Language Support noteworthy Pull requests and fixed issues that should be highlighted to users
Projects
None yet
Milestone
11.1.0
Development

Successfully merging this pull request may close these issues.
2 participants
@ewaterlander @jonahgraham