Account for new header layout in DWARF v5 #204
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jld01
reviewed
Dec 9, 2022
There was a problem hiding this comment.
@jonahgraham thanks for investigating. I've fetched this PR and can confirm it eliminates the reported exception on Ubuntu 22.04 LTS. I expect this will affect users on multiple recent Linux distros so is a strong candidate for a possible 11.0.1 bugfix release despite the easy workaround.
|
Thanks @jld01 for having a look and testing. I'll try to spin up a 11.0.1 as soon as I can. |
f774fc8 to
828a988
Compare
|
I have now written a test and can see that this fix isn't sufficient enough, there are still OOB exceptions (not surprisingly). |
|
This change is part of #242 now |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #198
This change fixes #198, but it is a quick change to account for the new header layout in version 5. I have not reviewed any other changes that may need to be needed for DWARF v5 though.