Fix unhandled event loop exception when binary parser is not in plugin.xml #137
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…n.xml If a .cproject references a binary parser ID that is not in the plug-in XML, or in the XML, but marked as private, the UI cannot display the binary parsers and was raising an ArrayIndexOutOfBoundsException as below. This fix rewrites the array handling using collections. ```java !ENTRY org.eclipse.ui 4 0 2022-11-04 09:44:27.409 !MESSAGE Unhandled event loop exception !STACK 0 java.lang.ArrayIndexOutOfBoundsException: Index 7 out of bounds for length 7 at org.eclipse.cdt.ui.newui.BinaryParsTab.updateData(BinaryParsTab.java:253) at org.eclipse.cdt.ui.newui.AbstractCPropertyTab.setVisible(AbstractCPropertyTab.java:253) at org.eclipse.cdt.ui.newui.BinaryParsTab.setVisible(BinaryParsTab.java:221) at org.eclipse.cdt.ui.newui.AbstractCPropertyTab.handleTabEvent(AbstractCPropertyTab.java:630) at org.eclipse.cdt.ui.newui.AbstractPage.updateSelectedTab(AbstractPage.java:412) at org.eclipse.cdt.ui.newui.AbstractPage$4.widgetSelected(AbstractPage.java:382) ```
jonahgraham
commented
Nov 4, 2022
| } else { // project | ||
| ICConfigurationDescription[] cfgs = page.getCfgsEditable(); | ||
| ids = CoreModelUtil.getBinaryParserIds(cfgs); | ||
| } | ||
| Object[] data = new Object[configMap.size()]; |
There was a problem hiding this comment.
The key error is that size of data was wrong, it assumed that it needed to be the size of all plugin.xml defined binary parsers. It didn't account for ids having other ids, so the i variable below would be over incremented.
All this is solved by removing hard coded array sizes.
3 tasks
|
Thanks for the review @ruspl-afed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If a .cproject references a binary parser ID that is not in the plug-in XML, or in the XML, but marked as private, the UI cannot display the binary parsers and was raising an ArrayIndexOutOfBoundsException as below.
This fix rewrites the array handling using collections.
This is needed more-so now so that the changes proposed in #135 doesn't cause the above exception if a project references the old ID.
Steps to reproduce the bug:
The same could be observed by opening a project created with some third-party plug-in that defines such a binary parser and then opening that project without the third-party plug-in installed.