Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CDT.setup working set definitions: fix swapped LSP and LLVM #107

Merged
merged 1 commit into from
Oct 25, 2022

Conversation

ruspl-afed
Copy link
Member

Fix working set predicate patterns for "CDT LLVM" and "CDT LSP"

Fix working set predicate patterns for "CDT LLVM" and "CDT LSP"
@github-actions
Copy link

Test Results

0 tests   0 ✔️  0s ⏱️
0 suites  0 💤
0 files    0

Results for commit 4887cd3.

@ruspl-afed
Copy link
Member Author

@jonahgraham do you know the cause of delays in pipelines?

@jonahgraham
Copy link
Member

@jonahgraham do you know the cause of delays in pipelines?

In this case it looks like a test hung on GitHub actions:

2022-10-18T07:15:21.6974463Z Running org.eclipse.cdt.core.settings.model.CProjectDescriptionStorageTests
2022-10-18T13:06:55.5980324Z ##[error]The operation was canceled.

First time I have seen that, I am aware of some unstable tests, but haven't had time to look into it more than that.

For the continuous-integration/jenkins/branch Pending — This commit is being built it looks broken - I don't push to CDT's repo directly, so other than main and release branches it just may be that the Jenkinsfile needs to be improved.

PS. You may need to raise an issue with the helpdesk to delete the branch once you have merged it.

@ruspl-afed
Copy link
Member Author

PS. You may need to raise an issue with the helpdesk to delete the branch once you have merged it.

Oops, I thought branch deletion is allowed for committers, except "protected" branches.

Copy link
Member

@jonahgraham jonahgraham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

I don't think you need to wait for CI to merge this as CDT.setup changes are completely untested by any automated flow.

@ruspl-afed ruspl-afed merged commit fd256d5 into main Oct 25, 2022
@ruspl-afed
Copy link
Member Author

PS. You may need to raise an issue with the helpdesk to delete the branch once you have merged it.

Done. https://gitlab.eclipse.org/eclipsefdn/helpdesk/-/issues/2148

@eclipsewebmaster eclipsewebmaster deleted the setup_workspace_fix branch October 26, 2022 08:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants