Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CMake Clean has inverted colors compared to build #1059

Closed
jonahgraham opened this issue Jan 28, 2025 · 0 comments · Fixed by #1060
Closed

CMake Clean has inverted colors compared to build #1059

jonahgraham opened this issue Jan 28, 2025 · 0 comments · Fixed by #1060

Comments

@jonahgraham
Copy link
Member

As you can see from these screenshots that blue and black parts of the output seem inverted in the build vs clean

Build:

Image

vs Clean:

Image

Originally posted by @jonahgraham in #691

jonahgraham added a commit to jonahgraham/cdt that referenced this issue Jan 28, 2025
With some better Javadocs the cross referencing between IConsole
and the UI aspects of the console is a little easier to follow.

This resolves eclipse-cdt#1059 in two parts:

1. For Core Build System this update consistently uses info stream to
show information messages and output stream to be stdout of launched
build tool. This resolves the "Build Complete" appearing as the output
color when doing clean (See screenshots in eclipse-cdt#1059)

2. CBuildConfiguration.watchProcess(IConsole, IProgressMonitor) incorrectly
passed the info stream as the output stream. Mostly this was used for
the clean stage of builds. This resolves the CMake output like ("Cleaning
all built files...") appearing as the info color when doing clean (See
screenshots in eclipse-cdt#1059)

Fixes eclipse-cdt#1059
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant