ProcessFactory.java : envpToEnvMap() consider null envp

eclipse-cdt · Dec 6, 2022 · ea79d13 · ea79d13
1 parent ac64d4a
commit ea79d13
Showing 1 changed file with 11 additions and 8 deletions.
diff --git a/core/org.eclipse.cdt.core.native/src/org/eclipse/cdt/utils/spawner/ProcessFactory.java b/core/org.eclipse.cdt.core.native/src/org/eclipse/cdt/utils/spawner/ProcessFactory.java
@@ -62,9 +62,17 @@ private static TreeMap<String, String> newEmptyEnvironment() {
 		return environment;
 	}
 
-	private static TreeMap<String, String> envpToEnvMap(String[] envp) {
+	private static TreeMap<String, String> getDefaultEnvironment() {
 		TreeMap<String, String> environment = newEmptyEnvironment();
+		Map<String, String> env = new ProcessBuilder().environment();
+		environment.putAll(env);
+		return environment;
+	}
+
+	private static TreeMap<String, String> envpToEnvMap(String[] envp) {
+		TreeMap<String, String> environment;
 		if (envp != null) {
+			environment = newEmptyEnvironment();
 			for (String envstring : envp) {
 				int eqlsign = envstring.indexOf('=');
 				if (eqlsign != -1) {
@@ -73,17 +81,12 @@ private static TreeMap<String, String> envpToEnvMap(String[] envp) {
 					// Silently ignore envstrings lacking the required `='.
 				}
 			}
+		} else {
+			environment = getDefaultEnvironment();
 		}
 		return environment;
 	}
 
-	private static TreeMap<String, String> getDefaultEnvironment() {
-		TreeMap<String, String> environment = newEmptyEnvironment();
-		Map<String, String> env = new ProcessBuilder().environment();
-		environment.putAll(env);
-		return environment;
-	}
-
 	private static void appendEnvMapComparison(StringBuilder sb, TreeMap<String, String> environmentA,
 			TreeMap<String, String> environmentB) {
 		TreeMap<String, String> environmentC = newEmptyEnvironment();