Clangd configuration file (.clangd) manager #44
Conversation
364ae09 to
fdb734d
Compare
|
@jonahgraham the method I've a open questions: |
|
Fix for #42 |
fdb734d to
17ad55b
Compare
|
@jonahgraham can you please review if this fits your needs for managed projects? |
| IProject project = event.getProject(); | ||
| if (project != null && LspEditorPreferencesTester.preferLspEditor(project)) { | ||
| ICConfigurationDescription newConfig = newCProjectDecription.getDefaultSettingConfiguration(); | ||
| var cwdBuilder = newConfig.getBuildSetting().getBuilderCWD(); |
There was a problem hiding this comment.
Its too bad we can't just call org.eclipse.cdt.managedbuilder.makegen.IManagedBuilderMakefileGenerator.getBuildWorkingDir() directly, having to do the variable resolve and then split below is an unfortunate complication.
| IProject project = event.getProject(); | ||
| if (project != null && LspEditorPreferencesTester.preferLspEditor(project)) { | ||
| ICConfigurationDescription newConfig = newCProjectDecription.getDefaultSettingConfiguration(); | ||
| var cwdBuilder = newConfig.getBuildSetting().getBuilderCWD(); |
There was a problem hiding this comment.
Its too bad we can't just call org.eclipse.cdt.managedbuilder.makegen.IManagedBuilderMakefileGenerator.getBuildWorkingDir() directly, having to do the variable resolve and then split below is an unfortunate complication.
...clipse.cdt.lsp.editor.ui/src/org/eclipse/cdt/lsp/editor/ui/clangd/CProjectChangeMonitor.java
Show resolved
Hide resolved
| */ | ||
| @SuppressWarnings("unchecked") | ||
| public static void setCompilationDatabase(String configFileDirectory, String databasePath) throws IOException { | ||
| var configFile = new File(configFileDirectory, CLANGD_CONFIG_FILE_NAME); |
There was a problem hiding this comment.
A refresh of configFile at the end of this method is needed (or write to an IFile instead of a java.io.File)
There was a problem hiding this comment.
You're right. I'll use an IFile instead.
| private static final String EXPANDED_CDB_SETTING = "CompileFlags: {Add: -ferror-limit=500, CompilationDatabase: %s, Compiler: g++}\nDiagnostics:\n ClangTidy: {Add: modernize*, Remove: modernize-use-trailing-return-type}\n"; | ||
| private static final String DEFAULT_CDB_SETTING = "CompileFlags: {CompilationDatabase: %s}"; | ||
| private static final String MODIFIED_DEFAULT_CDB_SETTING = DEFAULT_CDB_SETTING + "\n"; | ||
| private static final String INVALID_YAML_SYNTAX_CONTAINS_TAB = "CompileFlags:\n\tCompilationDatabase: %s"; |
There was a problem hiding this comment.
The .clangd in CDT I added recently had tabs before the comments. clangd seems fine with it, but I have fixed it in CDT in eclipse-cdt/cdt#382
TBH - not sure how tab got in there in the first place, but I suspect the default text editor in Eclipse with default settings. Maybe we should add .clangd to the set of yml files, or contribute our own language mapping
There was a problem hiding this comment.
TBH - not sure how tab got in there in the first place, but I suspect the default text editor in Eclipse with default settings. Maybe we should add .clangd to the set of yml files, or contribute our own language mappin
Yepp, that's s a good point
Generates or updates the CompilationDatabase entry in the .clangd yaml file depending on the active build configuration.
17ad55b to
219921d
Compare
|
@jonahgraham I just pushed a new commit. Using IFile instead of file. The user will be informed if the yaml file syntax is errornous: |
|
The error popup looks good to me. |
|
@jonahgraham can you please merge this PR? |
| { | ||
| @Override | ||
| public IStatus runInUIThread(IProgressMonitor monitor) { | ||
| ErrorDialog.openError(getActiveShell(), title, errorText, status); |
There was a problem hiding this comment.
Why do we need to wrap ErrorDialog with UIJob?
Generates or updates the CompilationDatabase entry in the .clangd yaml file.