Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#357] add option to enable the database update in .clangd file #425

Merged
merged 3 commits into from
Feb 19, 2025

Conversation

ghentschke
Copy link
Contributor

..depending on active build configuration or cmake build type.

fixes #357

@ghentschke ghentschke changed the title [#357] add option to enable the dtabase update in .clangd file [#357] add option to enable the database update in .clangd file Feb 18, 2025
Copy link
Member

@ruspl-afed ruspl-afed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

is it better after API rework?

@ghentschke
Copy link
Contributor Author

is it better after API rework?

Which open API rework do you mean?

Copy link
Member

@ruspl-afed ruspl-afed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ruspl-afed
Copy link
Member

Which open API rework do you mean?

The rework of preferences API.

@ruspl-afed
Copy link
Member

@ghentschke do you plan to merge this one? Conflicts looks resolvable.

@ghentschke
Copy link
Contributor Author

I wanted to wait until the API refactoring is done.

@jonahgraham
Copy link
Member

@ghentschke I can rebase this if you don't get a chance so that we can get this into M3.

ghentschke and others added 3 commits February 19, 2025 19:18
…file

..depending on active build configuration or cmake build type.

fixes eclipse-cdt#357
when Restore Defaults has been pushed or `Enable project-specific
settings` has been disabled.
@ghentschke ghentschke merged commit 75d7cb6 into eclipse-cdt:main Feb 19, 2025
3 checks passed
@ghentschke ghentschke deleted the fix-357 branch February 19, 2025 18:29
@jonahgraham jonahgraham added this to the 3.0.0 milestone Mar 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Don't overwrite .clangd file in project root
3 participants