-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update to latest dependencies #271
Conversation
9920361
to
69ac83c
Compare
The Linuxtools build we need is running as https://ci.eclipse.org/linuxtools/job/linuxtools/job/master/321/ - should be ready in ~45 minutes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thank you!
Something went wrong with that build - now tracking https://ci.eclipse.org/linuxtools/job/linuxtools/job/master/323 |
With recent changes to Linuxtools we need to start building against 4.31 I-builds. The alternative is to not use nightly for linuxtools. Requires that eclipse-linuxtools/org.eclipse.linuxtools#324 be merged and a new build completes. Fixes eclipse-cdt#269
cf43ad8
to
d784221
Compare
/request-license-review |
Workflow run (with attached summary files): |
@ghentschke please re-review because I also needed to update to latest Tycho for everything to build and test successfully with latest platform. |
Failed with It is fine to merge with this broken to get the rest of the builds running if we are being blocked. But we should not release with license vetting failing. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
/request-license-review |
Workflow run (with attached summary files): |
I am not sure how to resolve this error:
I assume that something missing in the .github\workflows\licensecheck.yml |
I think the project's gitlab token has expired. I ran manually on my machine and it worked. It automatically raised an issue, but I don't know why dash licenses thinks it needs a review, so I will wait to hear back. In the meantime I raised a helpdesk ticket. |
A newer Tycho is needed to enable build and test against more recent platform. tycho-packaging-plugin is needed explicitly to ensure that the headers in MANIFEST.MF are not removed during build. This ensures cdt-lsp doesn't have this same problem as CDT had recently eclipse-cdt/cdt#551 The inclusion of tycho-packaging-plugin also contains the missing source references in the MANIFEST.MF outputs.
d784221
to
28347a0
Compare
I think we should merge this now so we can get all the other issues merged now. Any objection? It means until license issues are resolved the check-license check will continue to fail, which is annoying. |
Feel free to merge |
With recent changes to Linuxtools we need to start building against 4.31 I-builds.
The alternative is to not use nightly for linuxtools.
Requires that
eclipse-linuxtools/org.eclipse.linuxtools#324 be merged and a new build completes.
Fixes #269