Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to latest dependencies #271

Merged
merged 2 commits into from
Feb 22, 2024

Conversation

jonahgraham
Copy link
Member

With recent changes to Linuxtools we need to start building against 4.31 I-builds.

The alternative is to not use nightly for linuxtools.

Requires that
eclipse-linuxtools/org.eclipse.linuxtools#324 be merged and a new build completes.

Fixes #269

@jonahgraham
Copy link
Member Author

The Linuxtools build we need is running as https://ci.eclipse.org/linuxtools/job/linuxtools/job/master/321/ - should be ready in ~45 minutes.

Copy link
Contributor

@ghentschke ghentschke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thank you!

@jonahgraham
Copy link
Member Author

The Linuxtools build we need is running as https://ci.eclipse.org/linuxtools/job/linuxtools/job/master/321/ - should be ready in ~45 minutes.

Something went wrong with that build - now tracking https://ci.eclipse.org/linuxtools/job/linuxtools/job/master/323

With recent changes to Linuxtools we need to start building
against 4.31 I-builds.

The alternative is to not use nightly for linuxtools.

Requires that
eclipse-linuxtools/org.eclipse.linuxtools#324 be
merged and a new build completes.

Fixes eclipse-cdt#269
@jonahgraham jonahgraham force-pushed the linuxtools2 branch 2 times, most recently from cf43ad8 to d784221 Compare February 22, 2024 01:07
@jonahgraham
Copy link
Member Author

/request-license-review

Copy link

/request-license-review

⚠️ Failed to request review of not vetted licenses.

Workflow run (with attached summary files):
https://github.com/eclipse-cdt/cdt-lsp/actions/runs/7997939520

@jonahgraham
Copy link
Member Author

@ghentschke please re-review because I also needed to update to latest Tycho for everything to build and test successfully with latest platform.

@jonahgraham
Copy link
Member Author

/request-license-review

⚠️ Failed to request review of not vetted licenses.

Workflow run (with attached summary files): https://github.com/eclipse-cdt/cdt-lsp/actions/runs/7997939520

Failed with GitLabApiException: 401 Unauthorized I hope this resolves itself automatically in the morning.

It is fine to merge with this broken to get the rest of the builds running if we are being blocked. But we should not release with license vetting failing.

Copy link
Contributor

@ghentschke ghentschke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ghentschke
Copy link
Contributor

/request-license-review

Copy link

/request-license-review

⚠️ Failed to request review of not vetted licenses.

Workflow run (with attached summary files):
https://github.com/eclipse-cdt/cdt-lsp/actions/runs/8000156547

@ghentschke
Copy link
Contributor

ghentschke commented Feb 22, 2024

I am not sure how to resolve this error:

Error:  Failed to execute goal org.eclipse.dash:license-tool-plugin:1.1.1-SNAPSHOT:license-check (default-cli) on project org.eclipse.cdt.lsp.root: 
Execution default-cli of goal org.eclipse.dash:license-tool-plugin:1.1.1-SNAPSHOT:license-check failed: org.gitlab4j.api.GitLabApiException: 401 Unauthorized -> [Help 1]

I assume that something missing in the .github\workflows\licensecheck.yml

@jonahgraham
Copy link
Member Author

I think the project's gitlab token has expired. I ran manually on my machine and it worked. It automatically raised an issue, but I don't know why dash licenses thinks it needs a review, so I will wait to hear back. In the meantime I raised a helpdesk ticket.

A newer Tycho is needed to enable build and test against more
recent platform.

tycho-packaging-plugin is needed explicitly to ensure that
the headers in MANIFEST.MF are not removed during build. This
ensures cdt-lsp doesn't have this same problem as CDT had recently
eclipse-cdt/cdt#551

The inclusion of tycho-packaging-plugin also contains the missing
source references in the MANIFEST.MF outputs.
@jonahgraham
Copy link
Member Author

I think we should merge this now so we can get all the other issues merged now. Any objection? It means until license issues are resolved the check-license check will continue to fail, which is annoying.

@ghentschke
Copy link
Contributor

Feel free to merge

@jonahgraham jonahgraham merged commit 90a1a52 into eclipse-cdt:master Feb 22, 2024
2 of 3 checks passed
@jonahgraham jonahgraham deleted the linuxtools2 branch February 22, 2024 15:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CDT LSP builds broken because of a change in dependencies
2 participants