[#87] Set clangd fallbackFlags on Windows #103
Merged
+217
−18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ruspl-afed
reviewed
Jun 1, 2023
bundles/org.eclipse.cdt.lsp/src/org/eclipse/cdt/lsp/InitialFileManager.java
Show resolved
Hide resolved
...g.eclipse.cdt.lsp/src/org/eclipse/cdt/lsp/server/enable/HasLanguageServerPropertyTester.java
Outdated
Show resolved
Hide resolved
...g.eclipse.cdt.lsp/src/org/eclipse/cdt/lsp/server/enable/HasLanguageServerPropertyTester.java
Show resolved
Hide resolved
bundles/org.eclipse.cdt.lsp/src/org/eclipse/cdt/lsp/server/ICLanguageServerProvider.java
Show resolved
Hide resolved
bundles/org.eclipse.cdt.lsp/src/org/eclipse/cdt/lsp/LspPlugin.java
Outdated
Show resolved
Hide resolved
bundles/org.eclipse.cdt.lsp/src/org/eclipse/cdt/lsp/InitialFileManager.java
Show resolved
Hide resolved
...eclipse.cdt.lsp.clangd/src/org/eclipse/cdt/lsp/internal/clangd/editor/LspEditorUiPlugin.java
Outdated
Show resolved
Hide resolved
...rg.eclipse.cdt.lsp.clangd/src/org/eclipse/cdt/lsp/internal/clangd/ClangdFallbackManager.java
Outdated
Show resolved
Hide resolved
...rg.eclipse.cdt.lsp.clangd/src/org/eclipse/cdt/lsp/internal/clangd/ClangdFallbackManager.java
Show resolved
Hide resolved
a5752ae to
a2f1333
Compare
clangd has trouble on Windows machines to detect the system headers. Therefore we add the includes paths from the first project file opened by the LS client to the fallbackFlags. see https://clangd.llvm.org/extensions#compilation-commands LIMITATION: The include path detection by ICBuildConfiguration.getScannerInformation works currently only for the clang compiler. g++/gcc doesn't work. fixes eclipse-cdt#87
ruspl-afed
approved these changes
Jun 2, 2023
|
@ruspl-afed Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
clangd has trouble on Windows machines to detect the system headers. Therefore we add the includes paths from the first project file opened by the LS client to the fallbackFlags.
see https://clangd.llvm.org/extensions#compilation-commands
LIMITATION: The include path detection by
ICBuildConfiguration.getScannerInformation works currently only for the clang compiler. g++/gcc doesn't work.
fixes #87