Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

.h files are always highlighted with the c grammar #85

Closed
ddscharfe opened this issue May 17, 2023 · 2 comments
Closed

.h files are always highlighted with the c grammar #85

ddscharfe opened this issue May 17, 2023 · 2 comments
Milestone
1.0.0

Comments

@ddscharfe
Copy link
Contributor

E.g. C++ keywords in .h files are not highlighted.

One solution could be to always use the cpp grammar for header files by adding a content binding to org.eclipse.tm4e.registry.grammars

      <scopeNameContentTypeBinding
            contentTypeId="org.eclipse.cdt.core.cHeader"
            scopeName="cpp-grammar">
      </scopeNameContentTypeBinding>
@ghentschke
Copy link
Contributor

One solution could be to always use the cpp grammar for header files by adding a content binding to org.eclipse.tm4e.registry.grammars

Yep, that seems to be a good solutions to me.

ddscharfe added a commit to ddscharfe/eclipse-cdt-lsp that referenced this issue May 17, 2023
@ddscharfe
[eclipse-cdt#85] Always use cpp grammar for .h files
2f461f8 
Fixes issue eclipse-cdt#85
@ddscharfe ddscharfe mentioned this issue May 17, 2023
Merged
ghentschke pushed a commit that referenced this issue May 17, 2023
@ddscharfe @ghentschke
[#85] Always use cpp grammar for .h files
67774fa 
Fixes issue #85
@ghentschke
Copy link
Contributor

Fixed by #86

@jonahgraham jonahgraham added this to the 1.0.0 milestone Sep 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.0.0
Development

No branches or pull requests
3 participants
@jonahgraham @ddscharfe @ghentschke