Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Complete the implementation of preference override facilities for ConfigurationMetadataBase #429

Closed
ruspl-afed opened this issue Feb 19, 2025 · 1 comment
Closed

Complete the implementation of preference override facilities for ConfigurationMetadataBase #429

ruspl-afed opened this issue Feb 19, 2025 · 1 comment
Assignees
@ruspl-afed

Comments

@ruspl-afed
Copy link
Member

Currently ConfigurationMetadataBase supports override for boolean and String preferences only

We should complete the implementation, since this non-final class is a part of API and adding new methods later will require major version increment
@ruspl-afed ruspl-afed self-assigned this Feb 19, 2025
ruspl-afed added a commit to ruspl-afed/eclipse-cdt-lsp that referenced this issue Feb 19, 2025
@ruspl-afed
[eclipse-cdt#429] Complete the implementation of `ConfigurationMetada…
9ee2b70 
…taBase`

* add "override" method for the rest of supported preference types
ruspl-afed added a commit to ruspl-afed/eclipse-cdt-lsp that referenced this issue Feb 19, 2025
@ruspl-afed
[eclipse-cdt#429] Complete the implementation of `ConfigurationMetada…
7642fd4 
…taBase`

* add "override" method for the rest of supported preference types
ruspl-afed added a commit that referenced this issue Feb 19, 2025
@ruspl-afed
[#429] Complete the implementation of ConfigurationMetadataBase
69b8a08 
* add "override" method for the rest of supported preference types
@ruspl-afed
Copy link
Member Author

Fixed with #430

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ruspl-afed ruspl-afed

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@ruspl-afed